Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap build failing on Windows (MSVC) #98546

Closed
BlaCoiso opened this issue Jun 26, 2022 · 1 comment · Fixed by #98556 or #98566
Closed

Bootstrap build failing on Windows (MSVC) #98546

BlaCoiso opened this issue Jun 26, 2022 · 1 comment · Fixed by #98556 or #98566

Comments

@BlaCoiso
Copy link
Contributor

BlaCoiso commented Jun 26, 2022

Commit 418b1fa broke builds on Windows as llvm-config has a .exe extension but

let llvm_config = llvm_root.join("bin/llvm-config");
t!(filetime::set_file_times(&llvm_config, now, now));

does not take that into account, resulting in a file not found error and bootstrap panicking.

Patching line 163 with

let llvm_config = llvm_root.join("bin").join(exe("llvm-config", builder.config.build));

fixes the build.

@jyn514
Copy link
Member

jyn514 commented Jun 26, 2022

@BlaCoiso do you want to make a PR with that patch? :)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 27, 2022
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 27, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97389 (Improve memory ordering diagnostics)
 - rust-lang#97780 (Check ADT field is well-formed before checking it is sized)
 - rust-lang#98530 (compiletest: add issue number param to `known-bug`)
 - rust-lang#98556 (Fix builds on Windows (closes rust-lang#98546))
 - rust-lang#98561 (Fix spelling in SAFETY comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors closed this as completed in 15abd82 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants