Check ADT field is well-formed before checking it is sized #97780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit c1f4f98 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 26, 2022
…e-sized, r=jackh726 Check ADT field is well-formed before checking it is sized Fixes rust-lang#96810. There is one diagnostics regression, in [`src/test/ui/generic-associated-types/bugs/issue-80626.stderr`](https://github.com/rust-lang/rust/pull/97780/files#diff-53795946378e78a0af23a10277c628ff79091c18090fdc385801ee70c1ba6963). I am not super concerned about it, since it's GAT related. We _could_ fix it, possibly by using the `FieldSized` obligation cause code instead of `BuiltinDerivedObligation`. But that would require changing `Sized` trait confirmation and the `adt_sized_constraint` query.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97389 (Improve memory ordering diagnostics) - rust-lang#97780 (Check ADT field is well-formed before checking it is sized) - rust-lang#98530 (compiletest: add issue number param to `known-bug`) - rust-lang#98556 (Fix builds on Windows (closes rust-lang#98546)) - rust-lang#98561 (Fix spelling in SAFETY comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96810.
There is one diagnostics regression, in
src/test/ui/generic-associated-types/bugs/issue-80626.stderr. I am not super concerned about it, since it's GAT related.We could fix it, possibly by using the
FieldSizedobligation cause code instead ofBuiltinDerivedObligation. But that would require changingSizedtrait confirmation and theadt_sized_constraintquery.