Update Clippy #100419

flip1995 · 2022-08-11T18:13:43Z

Fix redundant_closure_call for single-expression async closures Add Sugg::asyncify Use Sugg for redundant_closure_call implementation

…lint is not allowed

Address issue rust-lang#99265 by checking each positionally used argument to see if the argument is named and adding a lint to use the name instead. This way, when named arguments are used positionally in a different order than their argument order, the suggested lint is correct. For example: ``` println!("{b} {}", a=1, b=2); ``` This will now generate the suggestion: ``` println!("{b} {a}", a=1, b=2); ``` Additionally, this check now also correctly replaces or inserts only where the positional argument is (or would be if implicit). Also, width and precision are replaced with their argument names when they exists. Since the issues were so closely related, this fix for issue rust-lang#99265 also fixes issue rust-lang#99266. Fixes rust-lang#99265 Fixes rust-lang#99266

Co-authored-by: Andy Caldwell <[email protected]>

…allowed

…rcho Read and use deprecated configuration (as well as emitting a warning) Original change written by `@flip1995` I've simply rebased to master and fixed up the formatting/tests. This change teaches the configuration parser which config key replaced a deprecated key and attempts to populate the latter from the former. If both keys are provided this fails with a duplicate key error (rather than attempting to guess which the user intended). Currently this on affects `cyclomatic-complexity-threshold` -> `cognitive-complexity-threshold` but will also be used in rust-lang#8974 to handle `blacklisted-names` -> `disallowed-names`. ``` changelog: deprecated configuration keys are still applied as if they were provided as their non-deprecated name. ``` - [x] `cargo test` passes locally - [x] Run `cargo dev fmt`

…rrors Generate correct suggestion with named arguments used positionally Address issue rust-lang#99265 by checking each positionally used argument to see if the argument is named and adding a lint to use the name instead. This way, when named arguments are used positionally in a different order than their argument order, the suggested lint is correct. For example: ``` println!("{b} {}", a=1, b=2); ``` This will now generate the suggestion: ``` println!("{b} {a}", a=1, b=2); ``` Additionally, this check now also correctly replaces or inserts only where the positional argument is (or would be if implicit). Also, width and precision are replaced with their argument names when they exists. Since the issues were so closely related, this fix for issue rust-lang#99265 also fixes issue rust-lang#99266. Fixes rust-lang#99265 Fixes rust-lang#99266

A `TokenStream` contains a `Lrc<Vec<(TokenTree, Spacing)>>`. But this is not quite right. `Spacing` makes sense for `TokenTree::Token`, but does not make sense for `TokenTree::Delimited`, because a `TokenTree::Delimited` cannot be joined with another `TokenTree`. This commit fixes this problem, by adding `Spacing` to `TokenTree::Token`, changing `TokenStream` to contain a `Lrc<Vec<TokenTree>>`, and removing the `TreeAndSpacing` typedef. The commit removes these two impls: - `impl From<TokenTree> for TokenStream` - `impl From<TokenTree> for TreeAndSpacing` These were useful, but also resulted in code with many `.into()` calls that was hard to read, particularly for anyone not highly familiar with the relevant types. This commit makes some other changes to compensate: - `TokenTree::token()` becomes `TokenTree::token_{alone,joint}()`. - `TokenStream::token_{alone,joint}()` are added. - `TokenStream::delimited` is added. This results in things like this: ```rust TokenTree::token(token::Semi, stmt.span).into() ``` changing to this: ```rust TokenStream::token_alone(token::Semi, stmt.span) ``` This makes the type of the result, and its spacing, clearer. These changes also simplifies `Cursor` and `CursorRef`, because they no longer need to distinguish between `next` and `next_with_spacing`.

…y, r=Manishearth Remove "blacklist" terminology Picking up where rust-lang/rust-clippy#5896 left off, this renames the `blacklisted_name` lint to `disallowed_names` (pluralised for compliance with naming conventions). The old name is still available though is deprecated (both in the lint name, and in the TOML configuration file). This has been proposed/requested a few times, most recently in rust-lang/rust-clippy#7582 where `@xFrednet` suggested pinging the Clippy team when a PR was created hence... cc: `@rust-lang/clippy` changelog: [`disallowed_names`] lint replaces `blacklisted_name`

Signed-off-by: Miguel Guarniz <[email protected]>

The expect_used lint is allow-by-default, so it would be better to show the case where this is enabled. Co-authored-by: Takayuki Nakata <[email protected]>

…ochenkov Remove `TreeAndSpacing`. A `TokenStream` contains a `Lrc<Vec<(TokenTree, Spacing)>>`. But this is not quite right. `Spacing` makes sense for `TokenTree::Token`, but does not make sense for `TokenTree::Delimited`, because a `TokenTree::Delimited` cannot be joined with another `TokenTree`. This commit fixes this problem, by adding `Spacing` to `TokenTree::Token`, changing `TokenStream` to contain a `Lrc<Vec<TokenTree>>`, and removing the `TreeAndSpacing` typedef. The commit removes these two impls: - `impl From<TokenTree> for TokenStream` - `impl From<TokenTree> for TreeAndSpacing` These were useful, but also resulted in code with many `.into()` calls that was hard to read, particularly for anyone not highly familiar with the relevant types. This commit makes some other changes to compensate: - `TokenTree::token()` becomes `TokenTree::token_{alone,joint}()`. - `TokenStream::token_{alone,joint}()` are added. - `TokenStream::delimited` is added. This results in things like this: ```rust TokenTree::token(token::Semi, stmt.span).into() ``` changing to this: ```rust TokenStream::token_alone(token::Semi, stmt.span) ``` This makes the type of the result, and its spacing, clearer. These changes also simplifies `Cursor` and `CursorRef`, because they no longer need to distinguish between `next` and `next_with_spacing`. r? `@petrochenkov`

Rollup of 5 pull requests Successful merges: - rust-lang#99311 (change maybe_body_owned_by to take local def id) - rust-lang#99862 (Improve type mismatch w/ function signatures) - rust-lang#99895 (don't call type ascription "cast") - rust-lang#99900 (remove some manual hash stable impls) - rust-lang#99903 (Add diagnostic when using public instead of pub) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…gillot Use LocalDefId for closures more

rustbot · 2022-08-11T18:13:45Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Manishearth · 2022-08-11T18:21:22Z

@bors r+ p=1

bors · 2022-08-11T18:21:24Z

📌 Commit ea90d4b has been approved by Manishearth

It is now in the queue for this repository.

bors · 2022-08-11T20:49:24Z

⌛ Testing commit ea90d4b with merge 00c071d1229639228176e80837672e56f58f9215...

bors · 2022-08-11T20:53:32Z

💔 Test failed - checks-actions

rust-log-analyzer · 2022-08-11T20:55:38Z

The job x86_64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

flip1995 · 2022-08-11T21:07:00Z

 downloading https://static.rust-lang.org/dist/2022-07-21/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to static.rust-lang.org:443

seems spurious

@bors retry

bors · 2022-08-12T00:12:55Z

⌛ Testing commit ea90d4b with merge b998821...

bors · 2022-08-12T02:58:45Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing b998821 to master...

rust-timer · 2022-08-12T04:42:26Z

Finished benchmarking commit (b998821): comparison url.

Instruction count

Primary benchmarks: ❌ relevant regressions found
Secondary benchmarks: ❌ relevant regression found

	mean¹	max	count²
Regressions ❌ (primary)	0.3%	0.9%	6
Regressions ❌ (secondary)	0.2%	0.2%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	0.9%	6

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

Primary benchmarks: ❌ relevant regression found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions ❌ (primary)	4.3%	4.3%	1
Regressions ❌ (secondary)	7.3%	7.3%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	-4.2%	3
All ❌✅ (primary)	4.3%	4.3%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

Mark-Simulacrum · 2022-08-16T13:03:14Z

Untagging as a regression. This PR didn't change any benchmarked code (including e.g. for PGO purposes).

Update Clippy r? `@Manishearth`

AaronC81 and others added 30 commits July 15, 2022 15:49

Fix suggestion for async in redundant_closure_call

4c43aa7

Fix redundant_closure_call for single-expression async closures Add Sugg::asyncify Use Sugg for redundant_closure_call implementation

Don't suggest using auto deref for block expressions

c990e29

Include the borrow in the suggestion for explicit_auto_deref

9ce0f82

Don't lint explicit_auto_deref on dyn Trait return

84e03b6

Don't lint exlipicit_auto_deref when other adjustments are needed

d602ab1

unwrap_used: Stop recommending using expect when the expect_used …

6ee03e2

…lint is not allowed

unwrap_used: Fix help, "an None" -> "None"

3e52031

Read and use deprecated configuration (as well as emitting a warning)

08e7ec4

Co-authored-by: Andy Caldwell <[email protected]>

Enable test empty_loop_no_std on windows

38e8013

Merge commit '3c7e7dbc1583a0b06df5bd7623dd354a4debd23d' into clippyup

67c405c

unwrap_used: Fix doc to not recommend expect when expect_used is not …

307b800

…allowed

Fix tests

1fd9f2d

Harden duplicates checking and add tests

ea25ef1

Rename "blacklisted name" to "disallowed name" throughout

2f48257

Change lint name to plural

66b4674

Add deprecation test for old configuration entry

56c9cc4

Change maybe_body_owned_by to take local def id

ca0996e

Signed-off-by: Miguel Guarniz <[email protected]>

Rename local_did to def_id

29a0f69

Signed-off-by: Miguel Guarniz <[email protected]>

Change enclosing_body_owner to return LocalDefId

ce5fa10

Signed-off-by: Miguel Guarniz <[email protected]>

Avoid ICE when fetching LocalDefId

6c1110e

Signed-off-by: Miguel Guarniz <[email protected]>

Apply suggestions from code review

23b4fe6

The expect_used lint is allow-by-default, so it would be better to show the case where this is enabled. Co-authored-by: Takayuki Nakata <[email protected]>

Use LocalDefId for closures more

6290772

Rollup merge of rust-lang#99186 - camsteffen:closure-localdefid, r=cj…

72649cf

…gillot Use LocalDefId for closures more

Update Cargo.lock

ea90d4b

rust-highfive assigned Manishearth Aug 11, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2022

bors merged commit b998821 into rust-lang:master Aug 12, 2022

rustbot added this to the 1.65.0 milestone Aug 12, 2022

This was referenced Aug 12, 2022

Visit attributes in more places. #96745

Merged

Add TyAlias into rustc_type_ir TyKind enum #97974

Closed

Stabilize lint_reasons in rustc (RFC 2383) #99063

Closed

rustbot added the perf-regression Performance regression. label Aug 12, 2022

Mark-Simulacrum removed the perf-regression Performance regression. label Aug 16, 2022

Jarcho pushed a commit to Jarcho/rust that referenced this pull request Aug 29, 2022

Auto merge of rust-lang#100419 - flip1995:clippyup, r=Manishearth

9ac237d

Update Clippy r? `@Manishearth`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #100419

Update Clippy #100419

flip1995 commented Aug 11, 2022

rustbot commented Aug 11, 2022

Manishearth commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

rust-log-analyzer commented Aug 11, 2022

flip1995 commented Aug 11, 2022

bors commented Aug 12, 2022

bors commented Aug 12, 2022

rust-timer commented Aug 12, 2022

Mark-Simulacrum commented Aug 16, 2022

Update Clippy #100419

Update Clippy #100419

Conversation

flip1995 commented Aug 11, 2022

rustbot commented Aug 11, 2022

Manishearth commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

rust-log-analyzer commented Aug 11, 2022

flip1995 commented Aug 11, 2022

bors commented Aug 12, 2022

bors commented Aug 12, 2022

rust-timer commented Aug 12, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Mark-Simulacrum commented Aug 16, 2022