Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that we don't add a new kind of breaking change with TAITs #105895

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Test that we don't add a new kind of breaking change with TAITs #105895

merged 1 commit into from
Dec 20, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 19, 2022

r? @lcnr

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2022
@oli-obk oli-obk mentioned this pull request Dec 19, 2022
Open
8 tasks
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 19, 2022

@bors r=lcnr (as discussed in zulip)

@bors
Copy link
Contributor

bors commented Dec 19, 2022

📌 Commit e62b75e has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 19, 2022

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 19, 2022
@matthiaskrgr
Rollup merge of rust-lang#105895 - oli-obk:tait_coherence, r=lcnr
310d6d5 
Test that we don't add a new kind of breaking change with TAITs

r? `@lcnr`
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2022
@bors
Auto merge of rust-lang#105918 - matthiaskrgr:rollup-mmazd62, r=matth…
c43bc13 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105801 (Realistic `Path::as_mut_os_str` doctest)
 - rust-lang#105860 (Add long error docs for `E0460` and `E0457`)
 - rust-lang#105895 (Test that we don't add a new kind of breaking change with TAITs)
 - rust-lang#105902 (docs: improve pin docs)
 - rust-lang#105910 (Update books)
 - rust-lang#105913 (rustdoc: remove width-limiter from source pages, stop overriding CSS)
 - rust-lang#105915 (Revert "Replace usage of `ResumeTy` in async lowering with `Context`")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f9bd718 into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oli-obk @rustbot @bors @lcnr