Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #105909

Closed
wants to merge 17 commits into from
Closed

Rollup of 5 pull requests #105909

wants to merge 17 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Noratrieb and others added 17 commits December 18, 2022 20:53
@Noratrieb
Use #[derive] instead of custom syntax in all newtype_index
b4d739e
@Ezrashaw
docs: add long-form error-code docs for E0460
7e66d45
@Ezrashaw
docs: add long-form error-code docs for E0457
540c3f4
@Noratrieb
Make #[custom_encodable] an attribute for newtype_index
88d5f7f 
Makes the syntax a little more rusty.
@Noratrieb
Make #[no_ord_impl] an attribute in newtype_index
9342994
@Noratrieb
Make #[max] an attribute in newtype_index
91c3c20
@Noratrieb
Make #[debug_format] an attribute in newtype_index
d679764 
This removes the `custom` format functionality as its only user was
trivially migrated to using a normal format.

If a new use case for a custom formatting impl pops up, you can add it
back.
@Noratrieb
A few small cleanups for newtype_index
8bfd645 
Remove the `..` from the body, only a few invocations used it and it's
inconsistent with rust syntax.

Use `;` instead of `,` between consts. As the Rust syntax gods inteded.
@Ezrashaw @GuillaumeGomez
more markdown list formatting
5ecac8e 
Co-authored-by: Guillaume Gomez <[email protected]>
@oli-obk
Test that we don't add a new kind of breaking change with TAITs
e62b75e
@ch-iv @vincenzopalazzo
docs: improve pin docs
7fc6b0c 
Co-authored-by: <@ch-iv>
@oli-obk
Don't panic on stable since miri is not available there
e5c92bc
@matthiaskrgr
Rollup merge of rust-lang#105860 - Ezrashaw:add-long-errors-0460-0457…
9cd5a4d 
…, r=jruderman,GuillaumeGomez

Add long error docs for `E0460` and `E0457`

Final docs for errors in rust-lang#61137 that have UI tests, my next PRs will also add these tests.

r? `@GuillaumeGomez`
@matthiaskrgr
Rollup merge of rust-lang#105880 - Nilstrieb:make-newtypes-less-not-r…
5ca7e81 
…ust, r=oli-obk

Improve syntax of `newtype_index`

This makes it more like proper Rust and also makes the implementation a lot simpler.

Mostly just turns weird flags in the body into proper attributes.

It should probably also be converted to an attribute macro instead of function-like, but that can be done in a future PR.
@matthiaskrgr
Rollup merge of rust-lang#105895 - oli-obk:tait_coherence, r=lcnr
310d6d5 
Test that we don't add a new kind of breaking change with TAITs

r? `@lcnr`
@matthiaskrgr
Rollup merge of rust-lang#105901 - oli-obk:no_miri_on_stable, r=Mark-…
e31a800 
…Simulacrum

Don't panic on stable since miri is not available there

fixes rust-lang#105816
@matthiaskrgr
Rollup merge of rust-lang#105902 - vincenzopalazzo:macros/pin_docs, r…
90eb8ab 
…=eholk

docs: improve pin docs

Override rust-lang#104195 with a full cleanup of the git history, now it should be ready to be merged.

r? `@eholk`

`@rustbot` label +A-async-await
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 19, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Dec 19, 2022

📌 Commit 90eb8ab has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
@bors
Copy link
Contributor

bors commented Dec 19, 2022

⌛ Testing commit 90eb8ab with merge ce125c1741f1fb08fd5943c06db1c1fbc4dc520e...

@bors
Copy link
Contributor

bors commented Dec 19, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 19, 2022
@matthiaskrgr
Copy link
Member Author

meh, network error

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr matthiaskrgr deleted the rollup-2ffh3ai branch December 22, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @bors @rust-log-analyzer @rustbot @Noratrieb @Ezrashaw @oli-obk @ch-iv