Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar : Missing "is" in format specifier diagnostic #106365

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Grammar : Missing "is" in format specifier diagnostic #106365

merged 2 commits into from
Jan 3, 2023

Conversation

gimbling-away
Copy link
Contributor

@gimbling-away gimbling-away commented Jan 2, 2023 •
edited
Loading

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@gimbling-away gimbling-away marked this pull request as ready for review January 2, 2023 15:19
@jyn514
Copy link
Member

jyn514 commented Jan 3, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 3, 2023

📌 Commit f8755ab has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2023
@jyn514 jyn514 changed the title Grammar : Missing "is" Grammar : Missing "is" in format specifier diagnostic Jan 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2023
@bors
Auto merge of rust-lang#106409 - matthiaskrgr:rollup-b58z1hz, r=matth…
ab10908 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104552 (warn newer available version of the x tool)
 - rust-lang#105681 (some fixes/improvements to mir::visit module)
 - rust-lang#106005 (Test the borrowck behavior of if-let guards)
 - rust-lang#106356 (clean: Remove `ctor_kind` from `VariantStruct`.)
 - rust-lang#106365 (Grammar : Missing "is" in format specifier diagnostic)
 - rust-lang#106388 (rustdoc: remove legacy box-sizing CSS)
 - rust-lang#106392 (`has_overflow` only if value is *not* within limit)
 - rust-lang#106402 (Fix dupe word typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 01d99f6 into rust-lang:master Jan 3, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@gimbling-away @rustbot @rust-log-analyzer @jyn514 @bors @wesleywiser