Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar : Missing "is" in format specifier diagnostic #106365

Merged
merged 2 commits into from
Jan 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_builtin_macros/src/format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ fn report_missing_placeholders(
if show_doc_note {
diag.note(concat!(
stringify!($kind),
" formatting not supported; see the documentation for `std::fmt`",
" formatting is not supported; see the documentation for `std::fmt`",
));
}
if suggestions.len() > 0 {
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/fmt/ifmt-bad-arg.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ LL | format!("foo %s baz", "bar");
| |
| help: format specifiers use curly braces: `{}`
|
= note: printf formatting not supported; see the documentation for `std::fmt`
= note: printf formatting is not supported; see the documentation for `std::fmt`

error: invalid format string: expected `'}'`, found `'t'`
--> $DIR/ifmt-bad-arg.rs:75:1
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/fmt/issue-89173.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ fn main() {
//~| NOTE: argument never used
//~| NOTE: argument never used
//~| NOTE: format specifiers use curly braces, and you have to use a positional or named parameter for the width
//~| NOTE: printf formatting not supported
//~| NOTE: printf formatting is not supported
}
2 changes: 1 addition & 1 deletion src/test/ui/fmt/issue-89173.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ note: format specifiers use curly braces, and you have to use a positional or na
|
LL | print!("%0*x", width, num);
| ^^^^
= note: printf formatting not supported; see the documentation for `std::fmt`
= note: printf formatting is not supported; see the documentation for `std::fmt`

error: aborting due to previous error

10 changes: 5 additions & 5 deletions src/test/ui/macros/format-foreign.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ LL | println!("%.*3$s %s!\n", "Hello,", "World", 4);
| | argument never used
| multiple missing formatting specifiers
|
= note: printf formatting not supported; see the documentation for `std::fmt`
= note: printf formatting is not supported; see the documentation for `std::fmt`
help: format specifiers use curly braces
|
LL | println!("{:.2$} {}!\n", "Hello,", "World", 4);
Expand All @@ -22,7 +22,7 @@ LL | println!("%1$*2$.*3$f", 123.456);
| |
| help: format specifiers use curly braces: `{0:1$.2$}`
|
= note: printf formatting not supported; see the documentation for `std::fmt`
= note: printf formatting is not supported; see the documentation for `std::fmt`

error: multiple unused formatting arguments
--> $DIR/format-foreign.rs:6:7
Expand All @@ -37,7 +37,7 @@ LL | | "###, "Hello,", "World", 4);
| |____| argument never used
| multiple missing formatting specifiers
|
= note: printf formatting not supported; see the documentation for `std::fmt`
= note: printf formatting is not supported; see the documentation for `std::fmt`
help: format specifiers use curly braces
|
LL ~ println!(r###"{:.2$}
Expand All @@ -60,7 +60,7 @@ LL | println!("Hi there, $NAME.", NAME="Tim");
| |
| help: format specifiers use curly braces: `{NAME}`
|
= note: shell formatting not supported; see the documentation for `std::fmt`
= note: shell formatting is not supported; see the documentation for `std::fmt`

error: multiple unused formatting arguments
--> $DIR/format-foreign.rs:15:32
Expand All @@ -72,7 +72,7 @@ LL | println!("$1 $0 $$ $NAME", 1, 2, NAME=3);
| | argument never used
| multiple missing formatting specifiers
|
= note: shell formatting not supported; see the documentation for `std::fmt`
= note: shell formatting is not supported; see the documentation for `std::fmt`
help: format specifiers use curly braces
|
LL | println!("{1} {0} $$ {NAME}", 1, 2, NAME=3);
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/macros/format-unused-lables.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ LL | "things"
LL | , UNUSED="args");
| ^^^^^^ named argument never used
|
= note: shell formatting not supported; see the documentation for `std::fmt`
= note: shell formatting is not supported; see the documentation for `std::fmt`

error: aborting due to 4 previous errors

2 changes: 1 addition & 1 deletion src/test/ui/macros/issue-92267.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ note: format specifiers use curly braces, and the conversion specifier `
|
LL | pub fn main() { println!("🦀%%%", 0) }
| ^^
= note: printf formatting not supported; see the documentation for `std::fmt`
= note: printf formatting is not supported; see the documentation for `std::fmt`

error: aborting due to previous error