Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a few trait goal candidates for the new solver #106384

Closed
wants to merge 10 commits into from
Closed

Implement a few trait goal candidates for the new solver #106384

wants to merge 10 commits into from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jan 2, 2023 •
edited
Loading

Not sure this is exactly the right structure for how to assemble these, but it's a first pass.

Since lcnr is gone for a bit for holiday, I'll update this PR in the mean time:

  • closures
  • fn ptrs
  • generators (Future + Generator, depending on the kind)
  • trait aliases
  • flesh out some structure to handle built-in traits like Copy/Clone

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2023

Some changes occurred to the core trait solver

cc @lcnr

@compiler-errors compiler-errors force-pushed the new-solver-new-candidates branch 4 times, most recently from 7c00542 to 9f73afe Compare January 11, 2023 00:02
@BoxyUwU BoxyUwU added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jan 11, 2023
@bors
Copy link
Contributor

bors commented Jan 11, 2023

☔ The latest upstream changes (presumably #106730) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jan 16, 2023

☔ The latest upstream changes (presumably #106395) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors compiler-errors mentioned this pull request Jan 17, 2023
Merged
@compiler-errors compiler-errors deleted the new-solver-new-candidates branch August 11, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @bors @BoxyUwU @lcnr