Rollup of 9 pull requests #106730

Noratrieb · 2023-01-11T16:30:58Z

Successful merges:

Collect and emit proper backtraces for delay_span_bugs #106321 (Collect and emit proper backtraces for delay_span_bugs)
Check impl's where clauses in consider_impl_candidate in experimental solver #106397 (Check impl's where clauses in consider_impl_candidate in experimental solver)
Improve fluent error messages #106427 (Improve fluent error messages)
add tests for div_duration_* functions #106570 (add tests for div_duration_* functions)
Polymorphization cleanup #106648 (Polymorphization cleanup)
Remove unnecessary lseek syscall when using std::fs::read #106664 (Remove unnecessary lseek syscall when using std::fs::read)
Disable "split dwarf inlining" by default. #106709 (Disable "split dwarf inlining" by default.)
Autolabel and ping wg for changes to new solver #106715 (Autolabel and ping wg for changes to new solver)
fix typo LocalItemId -> ItemLocalId #106717 (fix typo LocalItemId -> ItemLocalId)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

… solver

This matches clang's behavior and makes split-debuginfo behave as expected (i.e. actually split the debug info). Fixes rust-lang#106592

…ace, r=Nilstrieb Collect and emit proper backtraces for `delay_span_bug`s This is a follow-up to rust-lang#106317, which addresses this comment (rust-lang#106267 (comment)) which notes that `delay_span_bug`s' backtraces are nonsense. Captures and emits the backtrace of the delayed span bug when it's *created*, rather than using the backtrace of the place where delayed bugs are flushed. --- To test, I delayed a span bug during HIR typeck, specifically in `typeck_with_fallback`... Before, note `flush_delayed` on frame 18. This is at the end of the compilation session, far from where the bug is being delayed. ``` error: internal compiler error: test --> /home/ubuntu/test.rs:1:1 | 1 | fn main() {} | ^^^^^^^^^ | = note: delayed at compiler/rustc_hir_typeck/src/lib.rs:196:14 thread 'rustc' panicked at 'Box<dyn Any>', compiler/rustc_errors/src/lib.rs:1634:13 stack backtrace: 0: 0x7f9c3ec69dd1 - std::backtrace_rs::backtrace::libunwind::trace::h26056f81198c6594 at /home/ubuntu/rust2/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5 1: 0x7f9c3ec69dd1 - std::backtrace_rs::backtrace::trace_unsynchronized::hacfb345a0c6d5bb1 at /home/ubuntu/rust2/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 2: 0x7f9c3ec69dd1 - std::sys_common::backtrace::_print_fmt::h18ea6016ac8030f3 at /home/ubuntu/rust2/library/std/src/sys_common/backtrace.rs:65:5 3: 0x7f9c3ec69dd1 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::he35dde201d0c2d09 at /home/ubuntu/rust2/library/std/src/sys_common/backtrace.rs:44:22 4: 0x7f9c3ecee308 - core::fmt::write::h094ad263467a053c at /home/ubuntu/rust2/library/core/src/fmt/mod.rs:1208:17 5: 0x7f9c3ec8aaf1 - std::io::Write::write_fmt::hd47b4e2324b4d9b7 at /home/ubuntu/rust2/library/std/src/io/mod.rs:1682:15 6: 0x7f9c3ec69bfa - std::sys_common::backtrace::_print::h43044162653a17fc at /home/ubuntu/rust2/library/std/src/sys_common/backtrace.rs:47:5 7: 0x7f9c3ec69bfa - std::sys_common::backtrace::print::hc8605da258fa5aeb at /home/ubuntu/rust2/library/std/src/sys_common/backtrace.rs:34:9 8: 0x7f9c3ec4db87 - std::panicking::default_hook::{{closure}}::h9e37f23f75122a15 9: 0x7f9c3ec4d97b - std::panicking::default_hook::h602873a063f84da2 at /home/ubuntu/rust2/library/std/src/panicking.rs:286:9 10: 0x7f9c3f6672b2 - <alloc[48d7b30605060536]::boxed::Box<dyn for<'a, 'b> core[672e3947e150d6c6]::ops::function::Fn<(&'a core[672e3947e150d6c6]::panic::panic_info::PanicInfo<'b>,), Output = ()> + core[672e3947e150d6c6]::marker::Send + core[672e3947e150d6c6]::marker::Sync> as core[672e3947e150d6c6]::ops::function::Fn<(&core[672e3947e150d6c6]::panic::panic_info::PanicInfo,)>>::call at /home/ubuntu/rust2/library/alloc/src/boxed.rs:2002:9 11: 0x7f9c3f6672b2 - rustc_driver[f5b6d32d8905ecdd]::DEFAULT_HOOK::{closure#0}::{closure#0} at /home/ubuntu/rust2/compiler/rustc_driver/src/lib.rs:1204:17 12: 0x7f9c3ec4e0d3 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::hfd13333ca953ae8e at /home/ubuntu/rust2/library/alloc/src/boxed.rs:2002:9 13: 0x7f9c3ec4e0d3 - std::panicking::rust_panic_with_hook::h45753e10264ebe7e at /home/ubuntu/rust2/library/std/src/panicking.rs:692:13 14: 0x7f9c422a1aa3 - std[3330b4673efabfce]::panicking::begin_panic::<rustc_errors[1b15f4e7e49d1fd5]::ExplicitBug>::{closure#0} at /home/ubuntu/rust2/library/std/src/panicking.rs:608:9 15: 0x7f9c422a1a46 - std[3330b4673efabfce]::sys_common::backtrace::__rust_end_short_backtrace::<std[3330b4673efabfce]::panicking::begin_panic<rustc_errors[1b15f4e7e49d1fd5]::ExplicitBug>::{closure#0}, !> at /home/ubuntu/rust2/library/std/src/sys_common/backtrace.rs:137:18 16: 0x7f9c3f63a996 - std[3330b4673efabfce]::panicking::begin_panic::<rustc_errors[1b15f4e7e49d1fd5]::ExplicitBug> at /home/ubuntu/rust2/library/std/src/panicking.rs:607:12 17: 0x7f9c4227a496 - std[3330b4673efabfce]::panic::panic_any::<rustc_errors[1b15f4e7e49d1fd5]::ExplicitBug> at /home/ubuntu/rust2/library/std/src/panic.rs:61:5 18: 0x7f9c4227cdf7 - <rustc_errors[1b15f4e7e49d1fd5]::HandlerInner>::flush_delayed::<alloc[48d7b30605060536]::vec::Vec<rustc_errors[1b15f4e7e49d1fd5]::diagnostic::Diagnostic>, &str, rustc_errors[1b15f4e7e49d1fd5]::ExplicitBug> at /home/ubuntu/rust2/compiler/rustc_errors/src/lib.rs:1634:13 19: 0x7f9c422498cf - <rustc_errors[1b15f4e7e49d1fd5]::Handler>::flush_delayed at /home/ubuntu/rust2/compiler/rustc_errors/src/lib.rs:1225:9 [ FRAMES INTENTIONALLY OMITTED ] 44: 0x7f9c3f6f3584 - <std[3330b4673efabfce]::thread::Builder>::spawn_unchecked_::<rustc_interface[947706ead88047d0]::util::run_in_thread_pool_with_globals<rustc_interface[947706ead88047d0]::interface::run_compiler<core[672e3947e150d6c6]::result::Result<(), rustc_errors[1b15f4e7e49d1fd5]::ErrorGuaranteed>, rustc_driver[f5b6d32d8905ecdd]::run_compiler::{closure#1}>::{closure#0}, core[672e3947e150d6c6]::result::Result<(), rustc_errors[1b15f4e7e49d1fd5]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[672e3947e150d6c6]::result::Result<(), rustc_errors[1b15f4e7e49d1fd5]::ErrorGuaranteed>>::{closure#1} at /home/ubuntu/rust2/library/std/src/thread/mod.rs:549:30 45: 0x7f9c3f6f3584 - <<std[3330b4673efabfce]::thread::Builder>::spawn_unchecked_<rustc_interface[947706ead88047d0]::util::run_in_thread_pool_with_globals<rustc_interface[947706ead88047d0]::interface::run_compiler<core[672e3947e150d6c6]::result::Result<(), rustc_errors[1b15f4e7e49d1fd5]::ErrorGuaranteed>, rustc_driver[f5b6d32d8905ecdd]::run_compiler::{closure#1}>::{closure#0}, core[672e3947e150d6c6]::result::Result<(), rustc_errors[1b15f4e7e49d1fd5]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[672e3947e150d6c6]::result::Result<(), rustc_errors[1b15f4e7e49d1fd5]::ErrorGuaranteed>>::{closure#1} as core[672e3947e150d6c6]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} at /home/ubuntu/rust2/library/core/src/ops/function.rs:250:5 46: 0x7f9c3ec81968 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::he8b26fc22c6f51ec at /home/ubuntu/rust2/library/alloc/src/boxed.rs:1988:9 47: 0x7f9c3ec81968 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h5cf9cbe75a8c3ddc at /home/ubuntu/rust2/library/alloc/src/boxed.rs:1988:9 48: 0x7f9c3ec5f99c - std::sys::unix::thread::Thread::new::thread_start::h2d6dd4455e97d031 at /home/ubuntu/rust2/library/std/src/sys/unix/thread.rs:108:17 49: 0x7f9c37c69609 - start_thread 50: 0x7f9c3ead0133 - clone 51: 0x0 - <unknown> ``` After, note `typeck_with_fallback` on the 5th frame, that's where we *actually* need to be pointed to: ``` error: internal compiler error: no errors encountered even though `delay_span_bug` issued error: internal compiler error: test --> /home/ubuntu/test.rs:1:1 | 1 | fn main() {} | ^^^^^^^^^ | = note: delayed at 0: <rustc_errors::HandlerInner>::emit_diagnostic at ./compiler/rustc_errors/src/lib.rs:1279:29 1: <rustc_errors::HandlerInner>::delay_span_bug::<rustc_span::span_encoding::Span, &str> at ./compiler/rustc_errors/src/lib.rs:1553:9 2: <rustc_errors::Handler>::delay_span_bug::<rustc_span::span_encoding::Span, &str> at ./compiler/rustc_errors/src/lib.rs:995:9 3: <rustc_session::session::Session>::delay_span_bug::<rustc_span::span_encoding::Span, &str> at ./compiler/rustc_session/src/session.rs:600:9 4: rustc_hir_typeck::typeck_with_fallback::<rustc_hir_typeck::typeck::{closure#0}>::{closure#0} at ./compiler/rustc_hir_typeck/src/lib.rs:196:5 5: rustc_hir_typeck::typeck_with_fallback::<rustc_hir_typeck::typeck::{closure#0}> at ./compiler/rustc_hir_typeck/src/lib.rs:185:36 6: rustc_hir_typeck::typeck at ./compiler/rustc_hir_typeck/src/lib.rs:166:9 [ FRAMES INTENTIONALLY OMITTED ] 108: std::panicking::try::<core::result::Result<(), rustc_errors::ErrorGuaranteed>, core::panic::unwind_safe::AssertUnwindSafe<<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#1}::{closure#0}>> at ./library/std/src/panicking.rs:447:19 109: std::panic::catch_unwind::<core::panic::unwind_safe::AssertUnwindSafe<<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#1}::{closure#0}>, core::result::Result<(), rustc_errors::ErrorGuaranteed>> at ./library/std/src/panic.rs:140:14 110: <std::thread::Builder>::spawn_unchecked_::<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#1} at ./library/std/src/thread/mod.rs:549:30 111: <<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} at ./library/core/src/ops/function.rs:250:5 112: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once at ./library/alloc/src/boxed.rs:1988:9 113: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once at ./library/alloc/src/boxed.rs:1988:9 114: std::sys::unix::thread::Thread::new::thread_start at ./library/std/src/sys/unix/thread.rs:108:17 115: start_thread 116: clone ```

…, r=lcnr Check `impl`'s `where` clauses in `consider_impl_candidate` in experimental solver Check impl's nested predicates as part of the recursive evaluate in `consider_impl_candidate`. <sub>Unless, for some reason, these are intentionally **not** checked here -- in which case, I really don't understand where they're being checked...<sub> r? ```@lcnr```

Improve fluent error messages These have been really frustrating me while migrating diagnostics.

…Titor add tests for div_duration_* functions Per rust-lang#63139 (comment) this adds unit tests for the functions that will hopefully effectively demonstrate that `div_duration` is ready to be stabilized.

…-errors Polymorphization cleanup Split out of rust-lang#106233 Use a newtype instead of a bitset directly. This makes the code way easier to read and easier to adapt for future changes.

…e-lseek, r=cuviper Remove unnecessary lseek syscall when using std::fs::read Fixes rust-lang#106597 r? ```@bjorn3```

…_by_default, r=davidtwco Disable "split dwarf inlining" by default. This matches clang's behavior and makes split-debuginfo behave as expected (i.e. actually split the debug info). Fixes rust-lang#106592

Autolabel and ping wg for changes to new solver r? ```@lcnr```

fix typo LocalItemId -> ItemLocalId

Noratrieb · 2023-01-11T16:31:16Z

@bors r+ rollup=never p=9

bors · 2023-01-11T19:56:38Z

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing ef4046e to master...

rust-timer · 2023-01-11T19:59:11Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#106717	12984406716635c318ba2601a472d62ae5cb3f98
#106715	771ffc65cc6adeb8382f75dcb734fc23cfd5c7f1
#106709	28d6383a20203a942f27d95cd73e4a0840215807
#106664	40306d15c01aa204444bad40f144f67eab627212
#106648	31e458cecb1ee908068a512aae377eabeaffe4c2
#106570	8d2926f9e2470bef44b23043695cbd490b72a4ed
#106427	4ff2c51d9f634cd6ef7836d6ad82ebb0df7fe165
#106397	267a288529294a4e0c4b17f8849ec2e88dc7c0b5
#106321	0f72f44d56cbdd8e6b219a1eb38b0aa705c90907

previous master: b22c152958

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-11T21:15:36Z

Finished benchmarking commit (ef4046e): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.3%]	6
Regressions ❌ (secondary)	0.4%	[0.2%, 0.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.3%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.5%	[5.5%, 5.5%]	1
Improvements ✅ (primary)	-3.2%	[-4.1%, -2.5%]	10
Improvements ✅ (secondary)	-2.2%	[-4.9%, -0.6%]	87
All ❌✅ (primary)	-3.2%	[-4.1%, -2.5%]	10

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Noratrieb · 2023-01-11T21:20:39Z

@rust-timer build 28d6383a20203a942f27d95cd73e4a0840215807

Noratrieb · 2023-01-11T21:21:08Z

@rust-timer build 40306d15c01aa204444bad40f144f67eab627212

rust-timer · 2023-01-11T23:19:28Z

Finished benchmarking commit (28d6383a20203a942f27d95cd73e4a0840215807): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.8%	[4.8%, 4.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Noratrieb · 2023-01-12T06:31:54Z

@rust-timer build 40306d15c01aa204444bad40f144f67eab627212

rust-timer · 2023-01-12T08:40:41Z

Finished benchmarking commit (40306d15c01aa204444bad40f144f67eab627212): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[2.8%, 4.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.8%, -1.4%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Noratrieb · 2023-01-12T08:50:29Z

@rust-timer build 31e458cecb1ee908068a512aae377eabeaffe4c2

rust-timer · 2023-01-12T11:19:55Z

Finished benchmarking commit (31e458cecb1ee908068a512aae377eabeaffe4c2): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[5.4%, 5.4%]	1
Improvements ✅ (primary)	-3.0%	[-3.9%, -2.4%]	10
Improvements ✅ (secondary)	-2.2%	[-5.0%, -0.7%]	102
All ❌✅ (primary)	-3.0%	[-3.9%, -2.4%]	10

Cycles

This benchmark run did not return any relevant results for this metric.

Noratrieb · 2023-01-12T12:13:41Z

Weird, maybe it's just noise. whatever, let's also try the unlikely candidates
@rust-timer build 0f72f44d56cbdd8e6b219a1eb38b0aa705c90907

rust-timer · 2023-01-12T13:58:57Z

Finished benchmarking commit (0f72f44d56cbdd8e6b219a1eb38b0aa705c90907): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	11
Regressions ❌ (secondary)	0.4%	[0.2%, 1.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.3%]	11

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[5.1%, 5.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.7%, -2.1%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Noratrieb · 2023-01-12T14:19:04Z

#106321 seems to be the culprit, the same tiny regressions in incr builds. Pretty weird since that shouldn't have touched the happy path but maybe something from the flushing changed it? Or do we sometimes delay bugs in some weird ways anyways even on the happy path?
I'm inclined to ignore the regression since it's so tiny but maybe there's an easy fix
cc @compiler-errors

pnkfelix · 2023-01-18T17:33:33Z

My understanding is that the code running delay_span_bug should never cause any semantic effect for input source that satisfies Rust's static analyses. (Because the whole point is there are two cases: either the static analyses reject the input for some other reason, or the static analyses accept the input but then that causes the delay_span_bug to fire off an ICE.)

I too am confused about why #106321 could have caused a performance impact. (We don't benchmark the compiler against type-incorrect code, do we? Even if we do/did, none of the flagged cases represent such instances...)

I'm thus inclined to categorize this as noise and mark it as triaged; if @compiler-errors wants to look into it, that's fine, but we don't need to add it to our accumulated set of perf regression issues.

@rustbot label: +perf-regression-triaged

mejrs and others added 22 commits January 5, 2023 03:39

Improve fluent error messages

0b5d6ae

add tests for div_duration_* functions

9fd744b

Remove unnecessary lseek syscall when using std::fs::read

eae615d

Make translate_message return result and add tests

262ff86

Fix tests

4c0c32c

Check impl's where clauses in consider_impl_candidate in experimental…

36ee66c

… solver

Use newtype for unused generic parameters

2855794

Delete unused polymorphization code

a4b859e

Collect backtraces for delayed span-bugs too

05c1ac0

use with_capacity in read read_to_string

f7bc68b

Disable "split dwarf inlining" by default.

aca2f88

This matches clang's behavior and makes split-debuginfo behave as expected (i.e. actually split the debug info). Fixes rust-lang#106592

a

d031bef

fix typo LocalItemId -> ItemLocalId

cce2f5f

Rollup merge of rust-lang#106427 - mejrs:translation_errors, r=davidtwco

7347655

Improve fluent error messages These have been really frustrating me while migrating diagnostics.

Rollup merge of rust-lang#106570 - Xaeroxe:div-duration-tests, r=John…

c962b07

…Titor add tests for div_duration_* functions Per rust-lang#63139 (comment) this adds unit tests for the functions that will hopefully effectively demonstrate that `div_duration` is ready to be stabilized.

Rollup merge of rust-lang#106648 - Nilstrieb:poly-cleanup, r=compiler…

6e0c404

…-errors Polymorphization cleanup Split out of rust-lang#106233 Use a newtype instead of a bitset directly. This makes the code way easier to read and easier to adapt for future changes.

Rollup merge of rust-lang#106664 - chenyukang:yukang/fix-106597-remov…

9a820f7

…e-lseek, r=cuviper Remove unnecessary lseek syscall when using std::fs::read Fixes rust-lang#106597 r? ```@bjorn3```

Rollup merge of rust-lang#106709 - khuey:disable_split_dwarf_inlining…

082ff0f

…_by_default, r=davidtwco Disable "split dwarf inlining" by default. This matches clang's behavior and makes split-debuginfo behave as expected (i.e. actually split the debug info). Fixes rust-lang#106592

Rollup merge of rust-lang#106715 - BoxyUwU:new_solver_triagebot, r=lcnr

80c535f

Autolabel and ping wg for changes to new solver r? ```@lcnr```

Rollup merge of rust-lang#106717 - klensy:typo, r=lcnr

9aeef61

fix typo LocalItemId -> ItemLocalId

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2023

bors merged commit ef4046e into rust-lang:master Jan 11, 2023

rustbot added this to the 1.68.0 milestone Jan 11, 2023

Noratrieb deleted the rollup-f7p8dsa branch January 11, 2023 19:58

This was referenced Jan 11, 2023

Switch to EarlyBinder for const_param_default and impl_trait_ref queries #106696

Merged

Teach rustc to write the ICE backtrace and query stack to disk #106691

Closed

bors mentioned this pull request Jan 11, 2023

Implement a few trait goal candidates for the new solver #106384

Closed

5 tasks

rustbot added the perf-regression Performance regression. label Jan 11, 2023

This comment has been minimized.

Sign in to view

rustbot removed the perf-regression Performance regression. label Jan 11, 2023

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jan 12, 2023

pnkfelix mentioned this pull request Jan 18, 2023

Collect and emit proper backtraces for delay_span_bugs #106321

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #106730

Rollup of 9 pull requests #106730

Noratrieb commented Jan 11, 2023

Noratrieb commented Jan 11, 2023

bors commented Jan 11, 2023

rust-timer commented Jan 11, 2023

rust-timer commented Jan 11, 2023

Noratrieb commented Jan 11, 2023 •

edited

Loading

This comment has been minimized.

Noratrieb commented Jan 11, 2023

rust-timer commented Jan 11, 2023

Noratrieb commented Jan 12, 2023

This comment has been minimized.

rust-timer commented Jan 12, 2023

Noratrieb commented Jan 12, 2023

This comment has been minimized.

rust-timer commented Jan 12, 2023

Noratrieb commented Jan 12, 2023

This comment has been minimized.

rust-timer commented Jan 12, 2023

Noratrieb commented Jan 12, 2023 •

edited

Loading

pnkfelix commented Jan 18, 2023

Rollup of 9 pull requests #106730

Rollup of 9 pull requests #106730

Conversation

Noratrieb commented Jan 11, 2023

Noratrieb commented Jan 11, 2023

bors commented Jan 11, 2023

rust-timer commented Jan 11, 2023

rust-timer commented Jan 11, 2023

Overall result: ❌ regressions - ACTION NEEDED

Noratrieb commented Jan 11, 2023 • edited Loading

This comment has been minimized.

Noratrieb commented Jan 11, 2023

rust-timer commented Jan 11, 2023

Overall result: no relevant changes - no action needed

Noratrieb commented Jan 12, 2023

This comment has been minimized.

rust-timer commented Jan 12, 2023

Overall result: ❌ regressions - no action needed

Noratrieb commented Jan 12, 2023

This comment has been minimized.

rust-timer commented Jan 12, 2023

Overall result: ❌ regressions - no action needed

Noratrieb commented Jan 12, 2023

This comment has been minimized.

rust-timer commented Jan 12, 2023

Overall result: ❌ regressions - ACTION NEEDED

Noratrieb commented Jan 12, 2023 • edited Loading

pnkfelix commented Jan 18, 2023

Noratrieb commented Jan 11, 2023 •

edited

Loading

Noratrieb commented Jan 12, 2023 •

edited

Loading