Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustdoc] Convert more GUI tests colors to their original format #111549

Merged
merged 2 commits into from
May 14, 2023
Merged

[rustdoc] Convert more GUI tests colors to their original format #111549

merged 2 commits into from
May 14, 2023

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #111459.

The update for the browser-ui-test version is about improvements for color handling (alpha for hex format in particular).

r? @notriddle

@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review May 13, 2023 22:17
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 13, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 14, 2023

📌 Commit 91765d8 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2023
@bors
Auto merge of rust-lang#111552 - matthiaskrgr:rollup-4nidoti, r=matth…
0a0e045 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#111463 (Better diagnostics for `env!` where variable contains escape)
 - rust-lang#111477 (better diagnostics for `impl<..> impl Trait for Type`)
 - rust-lang#111534 (rustdoc-json: Add tests for `#![feature(inherent_associated_types)]`)
 - rust-lang#111549 ([rustdoc] Convert more GUI tests colors to their original format)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d1cd127 into rust-lang:master May 14, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 14, 2023
@GuillaumeGomez GuillaumeGomez deleted the update-gui-format branch May 14, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @notriddle @bors @rustbot