Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style-guide: Organizational and editing tweaks (no semantic changes) #112942

Merged
merged 15 commits into from
Jun 23, 2023
Merged

style-guide: Organizational and editing tweaks (no semantic changes) #112942

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3747d7f
style-guide: Move text about block vs visual indent to indentation se…
joshtriplett Jun 22, 2023
9280567
style-guide: Move and expand text about trailing commas
joshtriplett Jun 22, 2023
2c0dd90
style-guide: s/right-ward/rightward/
joshtriplett Jun 22, 2023
4c5bb06
style-guide: Consistently refer to rustfmt as `rustfmt`
joshtriplett Jun 22, 2023
d270af3
style-guide: Remove inaccurate statement about rustfmt
joshtriplett Jun 22, 2023
c5f8b2c
style-guide: Define (and capitalize) "ASCIIbetically"
joshtriplett Jun 22, 2023
20f2828
style-guide: Update cargo.md for authors being optional and not recom…
joshtriplett Jun 22, 2023
6f8f83f
style-guide: Avoid normative recommendations for formatting tool conf…
joshtriplett Jun 22, 2023
fec28b2
style-guide: Clarify advice on names matching keywords
joshtriplett Jun 22, 2023
c930b21
style-guide: Reword an awkwardly phrased recommendation (and fix a typo)
joshtriplett Jun 22, 2023
3e2449c
style-guide: Rephrase a confusingly ordered, ambiguous sentence (and …
joshtriplett Jun 22, 2023
a9d1db3
style-guide: Avoid hyphenating "semicolon"
joshtriplett Jun 22, 2023
5d63721
style-guide: Make link text in SUMMARY.md match the headings in the l…
joshtriplett Jun 22, 2023
f972e09
style-guide: Define what an item is
joshtriplett Jun 22, 2023
fcc23a3
style-guide: Avoid referring to the style team in the past tense
joshtriplett Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/doc/style-guide/src/items.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,10 +505,6 @@ use b;
Because of `macro_use`, attributes must also start a new group and prevent
re-ordering.

Note that tools which only have access to syntax (such as `rustfmt`) cannot
joshtriplett marked this conversation as resolved.
Show resolved Hide resolved
tell which imports are from an external crate or the std lib, etc.


#### Ordering list import

Names in a list import must be sorted ascii-betically, but with `self` and
Expand Down