Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore-cross-compile remaining tests that run binaries #115378

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 30, 2023

Follow up to #114958

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2023
@Veykril
Copy link
Member Author

Veykril commented Aug 30, 2023

(sorry forgot to)
r? @lqd

@rustbot rustbot assigned lqd and unassigned Mark-Simulacrum Aug 30, 2023
@lqd
Copy link
Member

lqd commented Aug 30, 2023

These should be the last ones in your list of ignored tests, right?

@Veykril
Copy link
Member Author

Veykril commented Aug 30, 2023

Yes, these are the remaining ones

@lqd
Copy link
Member

lqd commented Aug 30, 2023

cool

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2023

📌 Commit 76ee9ac has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 30, 2023
`ignore-cross-compile` remaining tests that run binaries

Follow up to rust-lang#114958
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#115373 (Fix bors missing a commit when merging rust-lang#115355)
 - rust-lang#115378 (`ignore-cross-compile` remaining tests that run binaries)
 - rust-lang#115393 (Make `termcolor` types public in `rustc_errors`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a0d2cb0 into rust-lang:master Aug 31, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 31, 2023
@Veykril Veykril deleted the ignore-cross-compile branch June 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants