Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make termcolor types public in rustc_errors #115393

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

LegNeato
Copy link
Contributor

After #114104, rust-gpu is unable to create a custom Emitter as the bounds have changed to include WriteColor.

I was able to work around this by adding termcolor as a direct dependency, but I believe this should be exposed as part of rustc_errors proper.

See #102992 for why rust-gpu needs to create a custom emitter.

After rust-lang#114104, `rust-gpu` is unable to create a custom `Emitter` as the bounds have changed to include `WriteColor`.

I was able to work around this by adding `termcolor` as a direct dependency, but I believe this should be exposed as part of `rustc_errors` proper.

See rust-lang#102992 for why `rust-gpu` needs to create a custom emitter.
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2023
@compiler-errors
Copy link
Member

r? @oli-obk since you added this

@rustbot rustbot assigned oli-obk and unassigned cjgillot Aug 30, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Aug 30, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2023

📌 Commit da86cdf has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2023
@klensy
Copy link
Contributor

klensy commented Aug 31, 2023

This need comment over pub that it used by external crate, otherwise will be eventually removed, as unused.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#115373 (Fix bors missing a commit when merging rust-lang#115355)
 - rust-lang#115378 (`ignore-cross-compile` remaining tests that run binaries)
 - rust-lang#115393 (Make `termcolor` types public in `rustc_errors`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 82675f6 into rust-lang:master Aug 31, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 31, 2023
LegNeato added a commit to LegNeato/rust that referenced this pull request Sep 1, 2023
As suggested in rust-lang#115393, add a comment so someone doesn't clean these up.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 1, 2023
Add comment so pub items are not removed

As suggested in rust-lang#115393, add a comment so someone doesn't clean these up.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 2, 2023
Add comment so pub items are not removed

As suggested in rust-lang/rust#115393, add a comment so someone doesn't clean these up.
@LegNeato LegNeato deleted the patch-1 branch September 16, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants