Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #115452

Merged
merged 12 commits into from
Sep 1, 2023
Merged

Rollup of 5 pull requests #115452

merged 12 commits into from
Sep 1, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 12 commits August 31, 2023 17:27
As suggested in rust-lang#115393, add a comment so someone doesn't clean these up.
miri ABI check: fix handling of 1-ZST; don't accept sign differences

r? `@oli-obk`
…r=oli-obk

diagnostics: avoid wrong `unused_parens` on `x as (T) < y`

Fixes rust-lang#106413
Fixes rust-lang#80636
…iper

fix version for abi_thiscall to 1.73.0, which was forgotten to change when stabilized and (later) moved to beta

See:

rust-lang#114562 (comment)
rust-lang#115056 (comment)
https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/1.2E72.2E0/near/387695644

Should be backported to beta too.
Add comment so pub items are not removed

As suggested in rust-lang#115393, add a comment so someone doesn't clean these up.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 1, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit ead5f80 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@bors
Copy link
Contributor

bors commented Sep 1, 2023

⌛ Testing commit ead5f80 with merge 270eb58...

@bors
Copy link
Contributor

bors commented Sep 1, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 270eb58 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2023
@bors bors merged commit 270eb58 into rust-lang:master Sep 1, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 1, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#115411 miri ABI check: fix handling of 1-ZST; don't accept sign di… 1d0470ca5050ae558467329463585ebb16c327d7 (link)
#115424 diagnostics: avoid wrong unused_parens on x as (T) < y 275d2ff667d02b456cf4085cd4cf168d4f1752ac (link)
#115425 remove unnecessary heap allocation 4ef704eab2d2df630cb4945912b08ff4144bdc38 (link)
#115446 fix version for abi_thiscall to 1.73.0, which was forgotten… c61f9ee412a149edc09c0957d472225b4200e7dc (link)
#115447 Add comment so pub items are not removed 0396e2e9300432af55c5cb74e3b12ed8c99e5e61 (link)

previous master: 361f8ba847

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (270eb58): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [0.5%, 2.1%] 4
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 2
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) 0.6% [-0.5%, 2.1%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.502s -> 630.43s (-0.17%)
Artifact size: 316.59 MiB -> 316.63 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-he30fhv branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants