rustc_mir_build: Enforce rustc::potential_query_instability lint
#118863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes might have occurred in exhaustiveness checking cc @Nadrieril |
cjgillot
reviewed
Dec 12, 2023
Enselic
force-pushed
the
rustc_mir-build-query-stability
branch
from
3e442fc
to
9c6d5d1
Compare
| // Look at the first witness. | ||
| collect_non_exhaustive_tys(cx, &witnesses[0], &mut non_exhaustive_tys); | ||
|
|
||
| // Make order of diagnostics deterministic. | ||
| non_exhaustive_tys.sort(); |
There was a problem hiding this comment.
FxIndexSet will maintain its insertion order as the iteration order. Since it is filled in a deterministic way, we don't need to do any sorting (and also don't need to #[allow] the lint below).
There was a problem hiding this comment.
Oops, good catch, thanks. Done.
Stop allowing `rustc::potential_query_instability` on all of `rustc_mir_build` and instead allow it on a case-by-case basis if it is safe to do so. In this crate there was no instance of the lint remaining.
Enselic
force-pushed
the
rustc_mir-build-query-stability
branch
from
9c6d5d1
to
5644a53
Compare
michaelwoerister
approved these changes
Dec 15, 2023
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2023
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#113091 (Don't merge cfg and doc(cfg) attributes for re-exports) - rust-lang#115660 (rustdoc: allow resizing the sidebar / hiding the top bar) - rust-lang#118863 (rustc_mir_build: Enforce `rustc::potential_query_instability` lint) - rust-lang#118909 (Some cleanup and improvement for invalid ref casting impl) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2023
Rollup merge of rust-lang#118863 - Enselic:rustc_mir-build-query-stability, r=michaelwoerister rustc_mir_build: Enforce `rustc::potential_query_instability` lint Stop allowing `rustc::potential_query_instability` on all of `rustc_mir_build` and instead allow it on a case-by-case basis if it is safe to do so. In this crate there was only one instance of the lint, and it was safe to allow. Part of rust-lang#84447 which is E-help-wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop allowing
rustc::potential_query_instabilityon all ofrustc_mir_buildand instead allow it on a case-by-case basis if it is safe to do so. In this crate there was only one instance of the lint, and it was safe to allow.Part of #84447 which is E-help-wanted.