Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup and improvement for invalid ref casting impl #118909

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Dec 13, 2023

This PR makes some cleanups and improvements to the invalid_reference_casting implementation in preparation for linting on new patterns, while reusing most of the logic.

r? @est31 (feel free to re-assign)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2023
@Urgau Urgau force-pushed the cleanup-improvement-invalid_ref_casting branch from 3fe1a80 to 30addf2 Compare December 13, 2023 15:46
compiler/rustc_lint/src/reference_casting.rs Outdated Show resolved Hide resolved
compiler/rustc_lint/src/reference_casting.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023
@Urgau Urgau force-pushed the cleanup-improvement-invalid_ref_casting branch from 30addf2 to ac01824 Compare December 14, 2023 16:25
@Urgau Urgau force-pushed the cleanup-improvement-invalid_ref_casting branch from ac01824 to 4839cca Compare December 14, 2023 16:27
@Urgau
Copy link
Member Author

Urgau commented Dec 14, 2023

Addressed (or commented) on all review comments, CI is passing. Should be ready for another round of review.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2023
@est31
Copy link
Member

est31 commented Dec 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 15, 2023

📌 Commit 4839cca has been approved by est31

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#113091 (Don't merge cfg and doc(cfg) attributes for re-exports)
 - rust-lang#115660 (rustdoc: allow resizing the sidebar / hiding the top bar)
 - rust-lang#118863 (rustc_mir_build: Enforce `rustc::potential_query_instability` lint)
 - rust-lang#118909 (Some cleanup and improvement for invalid ref casting impl)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 25216b6 into rust-lang:master Dec 15, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
Rollup merge of rust-lang#118909 - Urgau:cleanup-improvement-invalid_ref_casting, r=est31

Some cleanup and improvement for invalid ref casting impl

This PR makes some cleanups and improvements to the `invalid_reference_casting` implementation in preparation for linting on new patterns, while reusing most of the logic.

r? `@est31` (feel free to re-assign)
@rustbot rustbot added this to the 1.76.0 milestone Dec 15, 2023
@Urgau Urgau deleted the cleanup-improvement-invalid_ref_casting branch December 15, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants