Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial std library support for NuttX #130595

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Initial std library support for NuttX #130595

merged 1 commit into from
Sep 25, 2024

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Sep 20, 2024

This PR add the initial libstd support for NuttX platform (Tier 3), currently it depends on rust-lang/libc#3909 which provide the essential libc definitions.

@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 20, 2024
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130755) made this pull request unmergeable. Please resolve the merge conflicts.

@ibraheemdev
Copy link
Member

I assume this is not actionable until rust-lang/libc#3909 is merged?

@no1wudi
Copy link
Contributor Author

no1wudi commented Sep 25, 2024

I assume this is not actionable until rust-lang/libc#3909 is merged?

Yes, this PR depends on it.

Now the rust-lang/libc#3909 has been merged, after that the version of libc in Rust side should bump to a version include it.

I think this PR can be merged if it's OK, I'll update the libc version and document about std library support for NuttX in next PR once libc released.

@ibraheemdev
Copy link
Member

Alright, given that you are the maintainer of this tier3 target this should be good to merge.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 25, 2024

📌 Commit 24f622c has been approved by ibraheemdev

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130549 (Add RISC-V vxworks targets)
 - rust-lang#130595 (Initial std library support for NuttX)
 - rust-lang#130734 (Fix: ices on virtual-function-elimination about principal trait)
 - rust-lang#130787 (Ban combination of GCE and new solver)
 - rust-lang#130809 (Update llvm triple for OpenHarmony targets)
 - rust-lang#130810 (Don't trap into the debugger on panics under Linux)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b72787 into rust-lang:master Sep 25, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2024
Rollup merge of rust-lang#130595 - no1wudi:master, r=ibraheemdev

Initial std library support for NuttX

This PR add the initial libstd support for NuttX platform (Tier 3), currently it depends on rust-lang/libc#3909 which provide the essential libc definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants