Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RISC-V vxworks targets #130549

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Add RISC-V vxworks targets #130549

merged 4 commits into from
Sep 25, 2024

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Sep 19, 2024 •
edited
Loading

Risc-V 32 and RISC-V 64 targets are to be added in the target list.

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@biabbas biabbas marked this pull request as draft September 19, 2024 08:14
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@biabbas biabbas marked this pull request as ready for review September 19, 2024 10:59
@biabbas biabbas marked this pull request as draft September 19, 2024 11:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@biabbas biabbas force-pushed the riscv32_wrs_vxworks branch 2 times, most recently from 31bf4aa to 95f9a73 Compare September 19, 2024 11:49
@biabbas biabbas marked this pull request as ready for review September 19, 2024 12:08
@biabbas biabbas marked this pull request as draft September 19, 2024 12:10
@michaelmaitland
Copy link

Nit: Risc 32 and risc 64 targets are to be added in the target list. should say RISC-V instead of Risc and risc in PR description.

@biabbas biabbas changed the title Add riscv vxworks targets Add RISC-V vxworks targets Sep 20, 2024
@biabbas biabbas marked this pull request as ready for review September 20, 2024 03:51
@biabbas biabbas mentioned this pull request Sep 20, 2024
Merged
@nnethercote
Copy link
Contributor

@michaelmaitland: you seem to know more about this than I do, so please let me know when you think this is good to merge. Thanks!

@biabbas
Copy link
Contributor Author

biabbas commented Sep 20, 2024

I was able to build std and compile programs for the RISC-V target. Though I had to make some tweaks in libc. Once this gets merged, I can commit changes to libc.

@biabbas
Copy link
Contributor Author

biabbas commented Sep 20, 2024

4957eda are changes to workaround a bug. This bug seems to be a continuation of issue #128582.

@nnethercote
Copy link
Contributor

@michaelmaitland: have all your concerns been addressed?

@michaelmaitland
Copy link

@michaelmaitland: have all your concerns been addressed?

I don't have the power to un-resolve comments, but I added a comment in one of the resolved threads about what is passed in the “features” is redundant with what features are enabled by the “cpu” field. I think we can drop the features field.

This is the comment I refer to: #130549 (comment)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
michaelmaitland
michaelmaitland approved these changes Sep 25, 2024
View reviewed changes
Copy link

@michaelmaitland michaelmaitland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michaelmaitland
michaelmaitland approved these changes Sep 25, 2024
View reviewed changes
Copy link

@michaelmaitland michaelmaitland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nnethercote
Copy link
Contributor

Thanks, everyone!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 25, 2024

📌 Commit 6d229f8 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 25, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2024
@bors
Auto merge of rust-lang#130816 - matthiaskrgr:rollup-jy25phv, r=matth…
2933f68 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130549 (Add RISC-V vxworks targets)
 - rust-lang#130595 (Initial std library support for NuttX)
 - rust-lang#130734 (Fix: ices on virtual-function-elimination about principal trait)
 - rust-lang#130787 (Ban combination of GCE and new solver)
 - rust-lang#130809 (Update llvm triple for OpenHarmony targets)
 - rust-lang#130810 (Don't trap into the debugger on panics under Linux)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 508b433 into rust-lang:master Sep 25, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2024
@rust-timer
Unrolled build for rust-lang#130549
08c4cc9 
Rollup merge of rust-lang#130549 - biabbas:riscv32_wrs_vxworks, r=nnethercote

Add RISC-V vxworks targets

Risc-V 32 and RISC-V 64 targets are to be added in the target list.
@biabbas biabbas deleted the riscv32_wrs_vxworks branch September 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelmaitland michaelmaitland michaelmaitland approved these changes

@Noratrieb Noratrieb Noratrieb left review comments

@nnethercote nnethercote Awaiting requested review from nnethercote

Assignees

@nnethercote nnethercote

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
7 participants
@biabbas @rustbot @rust-log-analyzer @michaelmaitland @nnethercote @bors @Noratrieb