Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #33236

Closed
wants to merge 19 commits into from
Closed

Commits on Apr 15, 2016

  1. Configuration menu
    Copy the full SHA
    a3f5d8a View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2016

  1. Configuration menu
    Copy the full SHA
    4d0b0e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2016

  1. Update ownership.md

    Opening sentence was confusing and something cannot be "one of the most unique" (it either is or is not unique).
    Michael Tiller committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    f252cfa View commit details
    Browse the repository at this point in the history
  2. Opening sentence was confusing and something cannot be "one of the mo…

    …st unique" (it either is or is not unique).
    Michael Tiller committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    864eba8 View commit details
    Browse the repository at this point in the history
  3. Opening sentence was confusing and something cannot be "one of the mo…

    …st unique" (it either is or is not unique).
    Michael Tiller committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    f7ec687 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2016

  1. Configuration menu
    Copy the full SHA
    3e9ea3b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2016

  1. Improve error message about regions of function body

    bombless authored and 向越可 committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    9348618 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6343f26 View commit details
    Browse the repository at this point in the history
  3. Update references-and-borrowing.md

    add as 2nd example.
    kindlychung committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    10abb66 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2016

  1. Fix use of the move command in the Windows shell

    `move` work both in `cmd` and in Powershell. `mv` works only in Powershell and the book says nothing about which shell is recommended so this could confuse beginners.
    
    Closes rust-lang#33219.
    TomasHubelbauer committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    e6b9760 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d569228 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#32991 - kindlychung:patch-2, r=steveklabnik

    make the borrowing example more concrete
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    0fdce5c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#33056 - GuillaumeGomez:as_mut_ptr_example, …

    …r=steveklabnik
    
    Improve as_mut ptr method example
    
    r? @steveklabnik
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    d9c9c32 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#33095 - xogeny:xogeny-patch-1, r=steveklabnik

    Tweaks to sections related to Ownership
    
    Reading through these sections, I thought the intro text could be improved slightly.  So
    here is a PR that addresses what was bugging me about it. :-)
    
    Main issue was the wording of the opening sentence ("guide" is not clearly defined and the
    wording was a bit too terse in my opinion).  I also took issue with the term "one of the most
    unique".  Uniqueness is a `bool`, not an `f64`. :-)
    
    r? @steveklabnik
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    cc00ebe View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#33152 - bwinterton:master, r=steveklabnik

    Make HashSet::Insert documentation more consistent
    
    I have made the HashSet::Insert documentation more consistent in the use of the term 'value' vs 'key'. Also clarified that if _this_ value is present true is returned, instead of the ambiguous 'a value present'.
    
    r? @steveklabnik
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    be918b6 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#33212 - bombless:scope-of-function-body, r=…

    …nikomatsakis
    
    Improve error message about regions of function body
    
    "scope of parameters for functions" is harder for me to read than "scope of function body", I hope others feel the same, as in <https://play.rust-lang.org/?gist=b4df68b395b807698bd2ba98cf3d5ce3&version=stable&backtrace=0&run=1>
     Thank @Aatch for the help :)
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    98c91e0 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#33218 - oli-obk:interned_str_cmp, r=nikomat…

    …sakis
    
    allow InternedString to be compared to &str directly
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    e9e85e8 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#33234 - TomasHubelbauer:TomasHubelbauer-pat…

    …ch-1, r=GuillaumeGomez
    
    Fix use of the `move` command in the Windows shell
    
    `move` works both in `cmd` and in Powershell. `mv` works only in Powershell and the book says nothing about which shell is recommended so this could confuse beginners.
    
    Closes rust-lang#33219.
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    c316b48 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#33239 - eddyb:mir-temp-drops, r=arielb1

    mir: drop temps outside-in by scheduling the drops inside-out.
    
    It was backwards all along, but only noticeable with multiple drops in one rvalue scope. Fixes rust-lang#32433.
    Manishearth committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    651ae26 View commit details
    Browse the repository at this point in the history