- Fix note message, fix tests.

Part of rust-lang#35233
Fixes rust-lang#35184

Provide a cleaner documentation for 'write!'

Hello!

This is my attempt to fix rust-lang#35110

Any feedback is more than welcome!

Cheers!

…dturner

Update error format for E0130

Fixes rust-lang#35256 as part of rust-lang#35233

r? @jonathandturner

Ignore VS Code settings directory

r? @steveklabnik

…dturner

Update error format for E0326

Fixes rust-lang#35335 as part of rust-lang#35233

r? @jonathandturner

…rielb1

Update e0017 to new format

Updated `span_err!` to use `struct_span_err!` and provide a `span_label` that describes the error in context.

Updated the test to look for the `span_label`s that are provided now.

…omatsakis

run rustfmt on compiletest folder in src/tools/ folder

Remove unnecessary `main` functions in doc examples.

…rner

Shrink span to variant discriminant expression for E0081

Part of rust-lang#35233.
Extension of rust-lang#35353.
Fixes rust-lang#35224.

r? @jonathandturner

Add test for issue rust-lang#29053

This PR adds a test for rust-lang#29053 (currently fails on stage 0, but works with stage 1, as it should).

Fixes rust-lang#29053

Update Error Format for E0091 and E0092

Addresses [rust-lang#35228](rust-lang#35228) and [rust-lang#35229](rust-lang#35229) as part of [rust-lang#35233](rust-lang#35233).

Please let me know if there are any issues; first time contributor.

r? @jonathandturner

Update E0008 and E0007 to new format

Part of rust-lang#35233
A fix for rust-lang#35496

r? @jonathandturner

…ndturner

Do not span across nodes for E0004

Part of rust-lang#35233.
Fixes rust-lang#35529.

r? @arielb1

…athandturner

Updated E0433 to new error message. (no bonus)

Part of rust-lang#35345
r? @jonathandturner

Update E0038 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35500
"r? @jonathandturner

This doesn't compile yet, and I need help. In my naive solution, adding the span label makes our error message a mutable `errors::DiagnosticBuilder` pointer.

```bash
python src/bootstrap/bootstrap.py --step check-cfail E0038 --stage 1
```

```
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling rustc v0.0.0 (file:///home/nash/code/rust/src/librustc)
src/librustc/traits/error_reporting.rs:735:9: 735:12 error: mismatched types [E0308]
src/librustc/traits/error_reporting.rs:735         err
                                                   ^~~
src/librustc/traits/error_reporting.rs:735:9: 735:12 help: run `rustc --explain E0308` to see a detailed explanation
src/librustc/traits/error_reporting.rs:735:9: 735:12 note: expected type `core::option::Option<errors::DiagnosticBuilder<'tcx>>`
src/librustc/traits/error_reporting.rs:735:9: 735:12 note:    found type `core::option::Option<&mut errors::DiagnosticBuilder<'_>>`
error: aborting due to previous error
error: Could not compile `rustc`.

To learn more, run the command again with --verbose.

command did not execute successfully: "/home/nash/code/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "-j" "4" "--target" "x86_64-unknown-linux-gnu" "--release" "--features" " jemalloc" "--manifest-path" "/home/nash/code/rust/src/rustc/Cargo.toml"
expected success, got: exit code: 101
```

…athandturner

Updated E0045 to new error format (no bonus)

Part of rust-lang#35501
r? @jonathandturner

Update error message E0384 to new format

Part of rust-lang#35233
Fixes rust-lang#35184

r? @jonathandturner

Add tracking issue for `String::insert_str`

…t, r=jonathandturner

E0128 update error format

Fixes rust-lang#35508

Part of rust-lang#35233

r? @jonathandturner

E0263 updated to new format.

Fixes rust-lang#35518. Part of rust-lang#35233.
r? @jonathandturner

Remove redundant `&mut ref mut` in doc for Result::as_mut()

While a good example of how `&mut ref mut` is a no-op, I don't think we should show that here :)
See https://users.rust-lang.org/t/mnemonic-for-reading-qualifiers/6853

r? @steveklabnik

Update E0133 to new format

Part of rust-lang#35233
Fix rust-lang#35509
r? @jonathandturner

Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed

…t, r=jonathandturner

E0072 update error format

Part of  rust-lang#35233

Fixes rust-lang#35506

r? @jonathandturner

The bonus for this issue currently seems to be impossible to do reliably, as the compiler seems to lack span information for item names alone, like `Foo` in `struct Foo { ... }`. It would be possible to hack something together by computing span offsets, but that seems like a solution that would be begging for trouble.

A proper solution to this would, of course, be to add span information to the right place (seems to be `rustc::hir::Item::name` but I may be wrong).