Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate where core::result::IntoIter is created. #35845

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Indicate where core::result::IntoIter is created. #35845

merged 1 commit into from
Sep 6, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Copy link
Member Author

r? @GuillaumeGomez

GuillaumeGomez
GuillaumeGomez reviewed Aug 20, 2016
View reviewed changes
src/libcore/result.rs
@@ -901,7 +901,12 @@ impl<'a, T> DoubleEndedIterator for IterMut<'a, T> {
#[stable(feature = "rust1", since = "1.0.0")]
impl<'a, T> ExactSizeIterator for IterMut<'a, T> {}

/// An iterator over the value in a `Ok` variant of a `Result`.
/// An iterator over the value in a `Ok` variant of a `Result`. This struct is
/// created by the `into_iter` method on [`Result`][`Result`] (provided by the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to write "[Result][Result]". Just "[Result]" is fine.

Can you also urls for into_iter please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to write "[Result][Result]". Just "[Result]" is fine.

I need to, otherwise, it will treat

[`Result`] (provided by the [`IntoIterator`] trait).

as a standard markdown link [...](...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest force push adds a link for into_iter.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2016

📌 Commit f4d55e1 has been approved by GuillaumeGomez

@eddyb eddyb mentioned this pull request Aug 22, 2016
Closed
eddyb added a commit to eddyb/rust that referenced this pull request Aug 22, 2016
@eddyb
Rollup merge of rust-lang#35845 - frewsxcv:result-into-iter, r=Guilla…
3e56c62 
…umeGomez

Indicate where `core::result::IntoIter` is created.

None
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Rollup merge of rust-lang#35845 - frewsxcv:result-into-iter, r=Guilla…
ca86803 
…umeGomez

Indicate where `core::result::IntoIter` is created.

None
@sophiajt sophiajt mentioned this pull request Aug 22, 2016
Closed
@sophiajt
Copy link
Contributor

@bors r-

Looks like this might have some broken links on OS X. This is from the latest rollup:

Linkcheck stage2 (x86_64-apple-darwin)
core/result/index.html:392: broken link - core/result/struct.Result.html
core/result/struct.IntoIter.html:54: broken link - core/result/struct.Result.html
std/path/struct.Path.html:474: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.Path.html:496: broken link - std/path/fmt/trait.Display.html
std/path/struct.PathBuf.html:598: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.PathBuf.html:620: broken link - std/path/fmt/trait.Display.html
std/result/index.html:392: broken link - std/result/struct.Result.html
std/result/struct.IntoIter.html:54: broken link - std/result/struct.Result.html

@sophiajt
Copy link
Contributor

Looks like #35786 has a similar issue. Maybe we can work together on a fix and apply to both?

@frewsxcv frewsxcv mentioned this pull request Aug 23, 2016
Closed
@frewsxcv
Copy link
Member Author

@GuillaumeGomez Did you ever find out what the issue was?

@GuillaumeGomez
Copy link
Member

@frewsxcv: Random tries mainly.

@frewsxcv frewsxcv force-pushed the result-into-iter branch 2 times, most recently from 63259fc to e5af9ef Compare September 3, 2016 16:12
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 3, 2016

@GuillaumeGomez Tests pass now. r?

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 4, 2016

📌 Commit 5652b62 has been approved by GuillaumeGomez

@Manishearth Manishearth mentioned this pull request Sep 5, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 5, 2016
@Manishearth
Rollup merge of rust-lang#35845 - frewsxcv:result-into-iter, r=Guilla…
acf98d9 
…umeGomez

Indicate where `core::result::IntoIter` is created.

None
@bors
Copy link
Contributor

bors commented Sep 5, 2016

⌛ Testing commit 5652b62 with merge cbe4de7...

bors added a commit that referenced this pull request Sep 5, 2016
@bors
Auto merge of #35845 - frewsxcv:result-into-iter, r=GuillaumeGomez
cbe4de7 
Indicate where `core::result::IntoIter` is created.

None
@bors
Copy link
Contributor

bors commented Sep 6, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing cbe4de7 to master...

bors added a commit that referenced this pull request Sep 6, 2016
@bors
Auto merge of #36274 - Manishearth:rollup, r=Manishearth
e1d0de8 
Rollup of 6 pull requests

- Successful merges: #35845, #35983, #36065, #36102, #36242, #36245
- Failed merges:
@bors bors merged commit 5652b62 into rust-lang:master Sep 6, 2016
@frewsxcv frewsxcv deleted the result-into-iter branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @GuillaumeGomez @bors @sophiajt