Rustc metadata diagnostics #36102
Rustc metadata diagnostics #36102
Conversation
GuillaumeGomez
force-pushed
the
rustc_metadata_diagnostics
branch
from
e414eb5
to
a425cb0
Compare
|
This is a redoing from #34970. |
| } | ||
|
|
||
| // In your crate: | ||
| #[macro_use(get_tacos, bring_beer)] // It imports macros get_tacos and |
There was a problem hiding this comment.
We could probably use a better example than "beer and tacos" ;)
There was a problem hiding this comment.
You're hard on business. :-/
GuillaumeGomez
force-pushed
the
rustc_metadata_diagnostics
branch
from
a425cb0
to
1f1bf37
Compare
|
Beer became pimiento! |
| } | ||
|
|
||
| // In your crate: | ||
| #[macro_use(get_tacos, get_pimiento)] // It imports macros get_tacos and |
There was a problem hiding this comment.
Should this be get_pimientos?
GuillaumeGomez
force-pushed
the
rustc_metadata_diagnostics
branch
from
1f1bf37
to
354d596
Compare
|
Should be good now. :'( |
|
@bors r+ |
|
📌 Commit 354d596 has been approved by |
|
⌛ Testing commit 354d596 with merge 975f34a... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors: retry |
|
⌛ Testing commit 354d596 with merge 9a4671f... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry On Fri, Sep 2, 2016 at 8:55 AM, bors [email protected] wrote:
|
|
⌛ Testing commit 354d596 with merge 302462d... |
|
💔 Test failed - auto-linux-64-opt-rustbuild |
GuillaumeGomez
force-pushed
the
rustc_metadata_diagnostics
branch
from
354d596
to
7c53eb9
Compare
|
The problem is that this test passes on OS X (since the tests are apparently compiled as libraries, so no linking happens). |
|
💥 Test timed out |
…ostics, r=jonathandturner Rustc metadata diagnostics r? @jonathandturner
|
Once #36320 is merged, it'll be easier to see from where the problem comes. |
|
@GuillaumeGomez: have you seen my comment above? |
|
@TimNN: Yes, however it can be the one which fails the tests since it isn't run. EDIT: woups, my browser didn't go the correct line. Hum... This is problematic if we cannot check an error code. :-/ |
|
I have set the failing test into "ignore mode". |
|
@GuillaumeGomez - please ignore the test only for OS X, if that's the troublesome platform: // ignore-macos |
|
@jonathandturner: Is that possible outside of |
|
@TimNN - yeah it may not work outside of that. @alexcrichton mentioned it had limitations on irc. |
|
If it doesn't support it in the part of code you're in, I guess it's fine to just ignore the whole thing. |
|
I'll work on adding later on. |
|
Any news? |
|
@GuillaumeGomez - if you can't ignore just for the platform where you are in the code, I'm okay with ignoring the test. |
|
cc @rust-lang/tools |
|
@GuillaumeGomez: I don't think (I just noticed that there is already a similar test for the compiler flag, linking to a Framework: https://github.com/rust-lang/rust/blob/master/src/test/compile-fail/manual-link-framework.rs). Edit: There is even a test for this exact case: https://github.com/rust-lang/rust/blob/master/src/test/compile-fail/osx-frameworks.rs, so maybe that can just be updated to include the error code as well |
|
It just fails without giving an error code. So I guess the better should be to keep it like this. |
|
@bors r+ |
|
📌 Commit d4c6a61 has been approved by |
…onathandturner Rustc metadata diagnostics r? @jonathandturner
1 similar comment
…tics, r=<try> Rustc metadata diagnostics r? @jonathandturner
r? @jonathandturner