rustbuild: Run debuginfo tests by default #38471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
This unfortunately may not land due to this bug, but I figure we can throw at bors and see what happens. |
|
@bors r+ p=1 |
|
📌 Commit d631367 has been approved by |
|
⌛ Testing commit d631367 with merge 59858d7... |
Yikes! |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry |
|
⌛ Testing commit d631367 with merge 848fe2c... |
|
💔 Test failed - auto-linux-64-x-android-t |
This fixes an accidental regression in rustbuild which stopped running debuginfo tests by default. Here we flag the test suites as `default(true)` to ensure that they're run on bots, for example.
alexcrichton
force-pushed
the
run-debuginfo-tests
branch
from
d631367
to
70ef94d
Compare
|
@bors: r=brson |
|
📌 Commit 70ef94d has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 20, 2016
…=brson rustbuild: Run debuginfo tests by default This fixes an accidental regression in rustbuild which stopped running debuginfo tests by default. Here we flag the test suites as `default(true)` to ensure that they're run on bots, for example.
|
⌛ Testing commit 70ef94d with merge a4e3e1a... |
|
@bors: retry force clean
|
bors
added a commit
that referenced
this pull request
Dec 20, 2016
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an accidental regression in rustbuild which stopped running debuginfo
tests by default. Here we flag the test suites as
default(true)to ensure thatthey're run on bots, for example.