Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse 0e+10 as a valid floating-point literal #40589

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Parse 0e+10 as a valid floating-point literal #40589

merged 1 commit into from
Mar 19, 2017

Conversation

topecongiro
Copy link
Contributor

Fixes issue #40408.

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa
Copy link
Member

nagisa commented Mar 18, 2017

Could you also add a test that 00e+10 also parses while you’re at it?

@topecongiro
Copy link
Contributor Author

@nagisa Rebased 😸

@eddyb
Copy link
Member

eddyb commented Mar 18, 2017

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Mar 18, 2017

📌 Commit 8eaac08 has been approved by nagisa

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 18, 2017
Rollup merge of rust-lang#40589 - topecongiro:floating-point-literal,…
d3d2866 
… r=nagisa

Parse 0e+10 as a valid floating-point literal

Fixes issue rust-lang#40408.
@arielb1 arielb1 mentioned this pull request Mar 18, 2017
Closed
bors added a commit that referenced this pull request Mar 18, 2017
@bors
Auto merge of #40644 - arielb1:rollup, r=arielb1
1d565ef 
Rollup of 22 pull requests

- Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621
- Failed merges: #40501, #40541
@arielb1 arielb1 mentioned this pull request Mar 19, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 19, 2017
Rollup merge of rust-lang#40589 - topecongiro:floating-point-literal,…
d3e5a45 
… r=nagisa

Parse 0e+10 as a valid floating-point literal

Fixes issue rust-lang#40408.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 19, 2017
@frewsxcv
Rollup merge of rust-lang#40589 - topecongiro:floating-point-literal,…
f2290da 
… r=nagisa

Parse 0e+10 as a valid floating-point literal

Fixes issue rust-lang#40408.
@frewsxcv frewsxcv mentioned this pull request Mar 19, 2017
Merged
bors added a commit that referenced this pull request Mar 19, 2017
@bors
Auto merge of #40651 - frewsxcv:rollup, r=frewsxcv
38c53f3 
Rollup of 13 pull requests

- Successful merges: #40441, #40445, #40562, #40564, #40583, #40588, #40589, #40590, #40603, #40611, #40621, #40646, #40648
- Failed merges:
@bors bors merged commit 8eaac08 into rust-lang:master Mar 19, 2017
@topecongiro topecongiro deleted the floating-point-literal branch March 22, 2017 10:33
@qnighy qnighy mentioned this pull request Apr 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@topecongiro @rust-highfive @nagisa @eddyb @bors @nrc