Don't stutter in operator trait descriptions #40818
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Wonderful, thanks so much! @bors: r+ rollup |
|
📌 Commit 8b92255 has been approved by |
Don't stutter in operator trait descriptions Fixes first item on rust-lang#29365. r? @steveklabnik
| @@ -768,7 +768,7 @@ macro_rules! neg_impl_unsigned { | |||
| // neg_impl_unsigned! { usize u8 u16 u32 u64 } | |||
| neg_impl_numeric! { isize i8 i16 i32 i64 i128 f32 f64 } | |||
|
|
|||
| /// The `Not` trait is used to specify the functionality of unary `!`. | |||
| /// The unary logical negation operator `!`. | |||
There was a problem hiding this comment.
Is the word “unary” really necessary here? Unlike - where there are binary and unary uses ! is always unary. Is the logical negation even defined in some other systems for multiple operands?
There was a problem hiding this comment.
I don't think it's necessary, but I don't mind it either.
Don't stutter in operator trait descriptions Fixes first item on rust-lang#29365. r? @steveklabnik
Fixes first item on #29365.
r? @steveklabnik