FromStr implementation example #40824
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libcore/str/mod.rs
Outdated
| /// .split(",") | ||
| /// .collect(); | ||
| /// | ||
| /// let x_fromstr = try!(coords[0].parse::<i32>()); |
There was a problem hiding this comment.
? should be used instead of try!.
src/libcore/str/mod.rs
Outdated
| /// .collect(); | ||
| /// | ||
| /// let x_fromstr = try!(coords[0].parse::<i32>()); | ||
| /// let y_fromstr = try!(coords[1].parse::<i32>()); |
|
Funny enough, this is how I originally mocked it up, but opted for the more verbose option on the side of caution haha Will make a quick change and recommit Thanks for the feedback! |
|
@bors: r+ rollup ha! awesome, thanks a ton! |
|
📌 Commit fb5e63f has been approved by |
…steveklabnik FromStr implementation example Referencing rust-lang#29375. Added example implementation of FromStr trait to API Documentation
…steveklabnik FromStr implementation example Referencing rust-lang#29375. Added example implementation of FromStr trait to API Documentation
Referencing #29375. Added example implementation of FromStr trait to API Documentation