cstore: return an immutable borrow from visible_parent_map
#41061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Apr 6, 2017
| @@ -556,6 +563,7 @@ impl CrateStore for cstore::CStore { | |||
| } | |||
| } | |||
|
|
|||
| visible_parent_map | |||
| drop(visible_parent_map); | |||
| self.visible_parent_map.borrow() | |||
There was a problem hiding this comment.
Why do we not have a downgrade method for RefMut -> Ref? cc @rust-lang/libs
|
@bors r+ |
|
📌 Commit 60381cd has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 7, 2017
cstore: return an immutable borrow from `visible_parent_map` This prevents an ICE when `visible_parent_map` is called multiple times, for example when an item referenced in an impl signature is imported from an `extern crate` statement occurs within an impl. Fixes rust-lang#41053. r? @eddyb
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 7, 2017
cstore: return an immutable borrow from `visible_parent_map` This prevents an ICE when `visible_parent_map` is called multiple times, for example when an item referenced in an impl signature is imported from an `extern crate` statement occurs within an impl. Fixes rust-lang#41053. r? @eddyb
bors
added a commit
that referenced
this pull request
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an ICE when
visible_parent_mapis called multiple times, for example when an item referenced in an impl signature is imported from anextern cratestatement occurs within an impl.Fixes #41053.
r? @eddyb