Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Use upstream LLVM repositories for Fuchsia #41130

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

petrhosek
Copy link
Contributor

The Fuchsia copies of LLVM repositories contain additional patches
for work-in-progress features and there is some amount of churn that
may break Rust. Use upstream LLVM repositories instead for building
the toolchain used by the Fuchsia builder.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@petrhosek
Copy link
Contributor Author

@alexcrichton could you please take a look? I hope the patch step is just the temporary solution until D28791 is resolved.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 7, 2017

📌 Commit b16101d has been approved by alexcrichton

@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

@bors r-

  • Fails tidy (lines too long)

The best fix is probably to just mark the build-toolchain.sh file with # ignore-tidy-linelength.

The Fuchsia copies of LLVM repositories contain additional patches
for work-in-progress features and there is some amount of churn that
may break Rust. Use upstream LLVM repositories instead for building
the toolchain used by the Fuchsia builder.
@petrhosek
Copy link
Contributor Author

Done.

@TimNN
Copy link
Contributor

TimNN commented Apr 7, 2017

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Apr 7, 2017

📌 Commit b135c12 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 7, 2017
…excrichton

travis: Use upstream LLVM repositories for Fuchsia

The Fuchsia copies of LLVM repositories contain additional patches
for work-in-progress features and there is some amount of churn that
may break Rust. Use upstream LLVM repositories instead for building
the toolchain used by the Fuchsia builder.
bors added a commit that referenced this pull request Apr 7, 2017
Rollup of 9 pull requests

- Successful merges: #40797, #41047, #41056, #41061, #41075, #41080, #41120, #41130, #41131
- Failed merges:
@bors bors merged commit b135c12 into rust-lang:master Apr 7, 2017
@bors
Copy link
Contributor

bors commented Apr 7, 2017

⌛ Testing commit b135c12 with merge 53f4bc3...

@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 19, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 19, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 19, 2017
[beta] travis: Use upstream LLVM repositories for Fuchsia

This is a backport of rust-lang#41130 which...

Closes rust-lang#41396
@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. O-fuchsia Operating system: Fuchsia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants