Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #45100

Merged
merged 22 commits into from
Oct 8, 2017
Merged

Rollup of 10 pull requests #45100

merged 22 commits into from
Oct 8, 2017

Commits on Oct 5, 2017

  1. Update trait summaries for std::fmt

    This patch is part of rust-lang#29355.
    Barret Rennie committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    276bebe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b50e8eb View commit details
    Browse the repository at this point in the history
  3. Modify Rc/Arc language around mutability

    There are a few exceptions to the rule that Arc/Rc are immutable. Rather
    than dig into the details, add "generally" to hint at this difference,
    as it's kind of a distraction at this point in the docs.
    
    Additionally, Arc's docs were slightly different here generally, so add
    in both the existing language and the exception.
    
    Fixes rust-lang#44105
    steveklabnik committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    5e251b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    98045fd View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2017

  1. Fix typo, per rust-lang#45057.

    hunteke committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    73ca15c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14c6c11 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2017

  1. Configuration menu
    Copy the full SHA
    45907f5 View commit details
    Browse the repository at this point in the history
  2. fmt: DRY

    tamird committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    19dcf91 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    41b105b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    691ab6c View commit details
    Browse the repository at this point in the history
  5. enable strict alignment (+strict-align) on ARMv6

    As discovered in rust-lang#44538 ARMv6 devices may or may not support unaligned memory accesses. ARMv6
    Linux *seems* to have no problem with unaligned accesses but this is because the kernel is stepping
    in to fix each unaligned memory access -- this incurs in a performance penalty.
    
    This commit enforces aligned memory accesses on all our in-tree ARM targets that may be used with
    ARMv6 devices. This should improve performance of Rust programs on ARMv6 devices. For the record,
    clang also applies this attribute when targeting ARMv6 devices that are not running Darwin or
    NetBSD.
    japaric committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    2b8f190 View commit details
    Browse the repository at this point in the history
  6. Add read_to_end implementation to &[u8]'s Read impl

    The default impl for read_to_end does a bunch of bookkeeping
    that isn't necessary for slices and is about 4 times slower
    on my machine.
    fhartwig committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    d52acbe View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2017

  1. Rollup merge of rust-lang#45018 - michaelwoerister:fix-dep-node-debug…

    …-recursion, r=eddyb
    
    incr.comp.: Fix infinite recursion in Debug implementation of DepNode
    
    Small bug fix. Depends on rust-lang#44901 to land first.
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    92a35d9 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#45042 - brennie:brennie/fmt-trait-summaries…

    …, r=steveklabnik
    
    Update trait summaries for std::fmt
    
    This patch is part of rust-lang#29355.
    
    r? @steveklabnik
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    4090e81 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#45052 - steveklabnik:gh44105, r=dtolnay

    Modify Rc/Arc language around mutability
    
    There are a few exceptions to the rule that Arc/Rc are immutable. Rather
    than dig into the details, add "generally" to hint at this difference,
    as it's kind of a distraction at this point in the docs.
    
    Additionally, Arc's docs were slightly different here generally, so add
    in both the existing language and the exception.
    
    Fixes rust-lang#44105
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    c238df1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#45053 - GuillaumeGomez:atomicbool-doc, r=Qu…

    …ietMisdreavus
    
    Add missing links for AtomicBool
    
    r? @rust-lang/docs
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    761efb3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#45058 - hunteke:fix_rustc_private_typo_2017…

    …Oct, r=shepmaster
    
    Fix typo, per rust-lang#45057.
    
    This looks like a simple string -- one character -- fix.  Given that I'm currently running low on battery, I have not actually compiled and tested this.  But I am fully confident this passes muster.  If not, I'll be maintainer-educated, yes?  ;-)
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    ae54d5e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#45060 - topecongiro:semi-in-local-span, r=p…

    …etrochenkov
    
    Add a semicolon to span for ast::Local
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    48cb6af View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    db202e3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#45083 - fhartwig:slice-read-to-end, r=bluss

    Add read_to_end implementation to &[u8]'s Read impl
    
    The default impl for read_to_end does a bunch of bookkeeping
    that isn't necessary for slices and is about 4 times slower
    on my machine.
    
    The following benchmark takes about 30 ns before this change and about 7 ns after:
    
    ```
    #[bench]
    fn bench_read_std(b: &mut Bencher) {
        let data = vec![0u8; 100];
        let mut v = Vec::with_capacity(200);
        b.iter(|| {
            let mut s = data.as_slice();
            v.clear();
            s.read_to_end(&mut v).unwrap();
        });
    }
    ```
    
    This solves the easy part of  rust-lang#44819 (I think extending this to `Take<&[u8]> `would require specialization)
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    262612c View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#45090 - rust-lang:petrochenkov-patch-1, r=a…

    …lexcrichton
    
    Document that `-C ar=PATH` doesn't do anything
    
    Are there any plans to use an external archiver in the future?
    IIRC, it was used before, but its use was replaced with LLVM's built-in archive management machinery. I can't found a relevant PR though. EDIT: Found it - rust-lang#26926!
    
    The `-C` option is stable so it still can't be removed right away even if there are no plans to use it (but maybe it can be deprecated?).
    Target specifications have a field for archiver as well, which is unused too (these ones are unstable, so I guess it can be removed).
    
    r? @alexcrichton
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    0489497 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#45094 - japaric:strict-align, r=alexcrichton

    enable strict alignment (+strict-align) on ARMv6
    
    As discovered in rust-lang#44538 ARMv6 devices may or may not support unaligned memory accesses. ARMv6
    Linux *seems* to have no problem with unaligned accesses but this is because the kernel is stepping
    in to fix each unaligned memory access -- this incurs in a performance penalty.
    
    This commit enforces aligned memory accesses on all our in-tree ARM targets that may be used with
    ARMv6 devices. This should improve performance of Rust programs on ARMv6 devices. For the record,
    clang also applies this attribute when targeting ARMv6 devices that are not running Darwin or
    NetBSD.
    
    closes rust-lang#44538
    r? @alexcrichton
    kennytm authored Oct 8, 2017
    Configuration menu
    Copy the full SHA
    7914e6f View commit details
    Browse the repository at this point in the history