Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 30 pull requests #52937

Merged
merged 86 commits into from
Aug 1, 2018
Merged

Rollup of 30 pull requests #52937

merged 86 commits into from
Aug 1, 2018

Commits on Jul 16, 2018

  1. Configuration menu
    Copy the full SHA
    acdafa0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b81ee0b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. Configuration menu
    Copy the full SHA
    ed5edcb View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2018

  1. Update clippy to latest master

    cmdln committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    7fb0a52 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. Configuration menu
    Copy the full SHA
    922bf1d View commit details
    Browse the repository at this point in the history
  2. Fix ws

    matklad authored Jul 27, 2018
    Configuration menu
    Copy the full SHA
    5f87f78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7750a0d View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2018

  1. Configuration menu
    Copy the full SHA
    173c330 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2018

  1. Configuration menu
    Copy the full SHA
    b6d3143 View commit details
    Browse the repository at this point in the history
  2. Fix From<LocalWaker>

    MajorBreakfast committed Jul 29, 2018
    Configuration menu
    Copy the full SHA
    ea25cf1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ccd7ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    90165b8 View commit details
    Browse the repository at this point in the history
  5. fix coding style

    fukatani committed Jul 29, 2018
    Configuration menu
    Copy the full SHA
    9845ee0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. update comment

    toidiu committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    2b25ee0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2994b27 View commit details
    Browse the repository at this point in the history
  3. Remove references to AUTHORS.txt file

    Refer instead to thanks page.
    dsciarra committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    c57deb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4b466ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f8d1dc8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aa7d7d0 View commit details
    Browse the repository at this point in the history
  7. Add targets for HermitCore (https://hermitcore.org) to the Rust compi…

    …ler and port libstd to it.
    
    As a start, the port uses the simplest possible configuration (no jemalloc, abort on panic)
    and makes use of existing Unix-specific code wherever possible.
    It adds targets for x86_64 (current main HermitCore platform) and aarch64 (HermitCore platform
    under development).
    
    Together with the patches to "liblibc" and "llvm", this enables HermitCore applications to be
    written in Rust.
    ColinFinck committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    e50f4ee View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    57c7742 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d4ff949 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7b9388b View commit details
    Browse the repository at this point in the history
  11. releases.md: fix 2 typos

    matthiaskrgr committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    d933174 View commit details
    Browse the repository at this point in the history
  12. Fix wrong issue number in the test name

    Mikhail Modin committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    b6b025b View commit details
    Browse the repository at this point in the history
  13. Remove the unstable std_unicode crate, deprecated since 1.27

    Its former contents are now in libcore.
    SimonSapin committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    d8b3c83 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4ca77f7 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    cbbcecb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9169934 View commit details
    Browse the repository at this point in the history
  17. run-pass/const-endianness: negate before to_le()

    `const LE_I128` needs parentheses to negate the value *before* calling
    `to_le()`, otherwise it doesn't match the operations performed in the
    black-boxed part of the test.  This only makes a tangible difference on
    big-endian targets.
    cuviper committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    1ea2765 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    c883edf View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Fix coding style.

    ColinFinck committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    4ad4ad0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5077399 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb7d8a1 View commit details
    Browse the repository at this point in the history
  4. Benchmarks for SmallVec

    ljedrz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    ca52648 View commit details
    Browse the repository at this point in the history
  5. Sort NLL error diagnostics by span in an attempt to make them match s…

    …ource order
    
    (and thus, hopefully, more closely match user expectation).
    pnkfelix committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    e8c2995 View commit details
    Browse the repository at this point in the history
  6. Blindly update the #[rustc_region] tests which got touched by the N…

    …LL diagnostic change.
    pnkfelix committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    6787e25 View commit details
    Browse the repository at this point in the history
  7. Update tests that use -Z borrowck=compare or #[feature(nll)] to a…

    …ccmmodate diagnostic change.
    pnkfelix committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    2677685 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    faf841a View commit details
    Browse the repository at this point in the history
  9. Fix a typo in unsize.rs

    RfC -> RFC
    pravic authored Jul 31, 2018
    Configuration menu
    Copy the full SHA
    830ac8c View commit details
    Browse the repository at this point in the history
  10. NLL: On "cannot move out of type" error, print original source before…

    … rewrite.
    
     * Arguably this change is sometimes injecting noise into the output
       (namely in the cases where the suggested rewrite is inline with the
       suggestion and we end up highlighting the original source code).
       I would not be opposed to something more aggressive/dynamic, like
       revising the suggestion code to automatically print the original
       source when necessary (e.g. when the error does not have a span
       that includes the span of the suggestion).
    
     * Also, as another note on this change: The doc comment for `Diagnostic::span_suggestion`
       says:
        /// The message
        ///
        /// * should not end in any punctuation (a `:` is added automatically)
        /// * should not be a question
        /// * should not contain any parts like "the following", "as shown"
    
       but the `:` is *not* added when the emitted line appears
       out-of-line relative to the suggestion. I find that to be an
       unfortunate UI experience.
    
    ----
    
    As a drive-by fix, also changed code to combine multiple suggestions
    for a pattern into a single multipart suggestion (which vastly
    improves user experience IMO).
    
    ----
    
    Includes the updates to expected NLL diagnostics.
    pnkfelix committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    a5a3f76 View commit details
    Browse the repository at this point in the history
  11. Pull out nightly checking to edges

    Parsing the code block's LangString (```foo) previously checked itself
    to see if we were on nightly; that isn't the right place to do so. Move
    that check slightly outwards to better abstract LangString.
    
    (This is also an optimization as we avoid the costly environment
    variable load of RUSTC_BOOTSTRAP).
    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    0af5a6b View commit details
    Browse the repository at this point in the history
  12. Provide warnings for invalid code blocks in markdown files

    Previously we would only warn on Rust code but we can also do so when
    testing markdown (the diag::Handler is available).
    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    ad40e45 View commit details
    Browse the repository at this point in the history
  13. Provide test configuration through struct

    This is far more sound than passing many different arguments of the same
    type.
    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    de5cebd View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    03e34f8 View commit details
    Browse the repository at this point in the history
  15. Further extract error code switch

    Removes dependency on UnstableFeatures from markdown rendering
    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    01d9555 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2216db9 View commit details
    Browse the repository at this point in the history
  17. Only run the sparc-abi test on sparc

    It is not required for LLVM to have SPARC target support, so it is
    necessary to only run this test when LLVM does support SPARC. Sadly, it
    isn’t possible to specify exactly this constraint. Instead, we specify
    that this test should run on SPARC host only (it surely is sane
    assumption to make that compiler running on a SPARC can generate
    SPARC, right?)
    
    Since you cannot specify multiple `only-*` to have it run on both 32-bit
    and 64-bit SPARC we pick 64-bit SPARC, because it is exactly what is
    being tested by this test.
    
    Fixes rust-lang#52881
    nagisa committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    40a6046 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    779792f View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    6b138f5 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    75ff0dd View commit details
    Browse the repository at this point in the history
  21. Remove global derive_id and reset_ids functions

    Previously these functions relied on TLS but we can instead thread the
    relevant state through explicitly.
    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    7bea518 View commit details
    Browse the repository at this point in the history
  22. Cleanup highlighting code

    Removes some unused code and de-publicizes structs
    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    8e65a46 View commit details
    Browse the repository at this point in the history
  23. Add dyn to Write

    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    4cd0047 View commit details
    Browse the repository at this point in the history
  24. Fixup test case

    Mark-Simulacrum committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    0f680b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. Configuration menu
    Copy the full SHA
    bcab7e2 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#52340 - cypher:document-from-trait-in-ffi, …

    …r=steveklabnik
    
    Document From trait implementations for OsStr, OsString, CString, and CStr
    
    As part of issue rust-lang#51430 (cc @skade).
    
    The allocation and copy claims should be double-checked.
    
    r? @steveklabnik
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    b7ee110 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#52628 - Mark-Simulacrum:rustdoc-cleanup-1, …

    …r=QuietMisdreavus
    
    Cleanup some rustdoc code
    
    Commits are mostly individual though some do depend on others.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    03df573 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#52732 - SimonSapin:spring, r=Mark-Simulacrum

    Remove unstable and deprecated APIs
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    acff794 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#52745 - commandline:master, r=oli-obk

    Update clippy to latest master
    
    r? @oli-obk
    
    There is a regression in the version in current nightly that falsely lints `println!` and `writeln!` that use named arguments, thinking all rhs values for the argument expressions are literals even when they are not. This update includes the fix for that.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    dafe335 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#52771 - matklad:patch-1, r=kennytm

    Clarify thread::park semantics
    
    It took me quite some time to realize that the example is not actually racy, so let's clarify it? :-)
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    06b91a4 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#52778 - ljedrz:readable_serialize, r=kennytm

    Improve readability of serialize.rs
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    714fd37 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#52810 - matthewjasper:more-immutablity, r=p…

    …nkfelix
    
    [NLL] Don't make "fake" match variables mutable
    
    These variables can't be mutated by the user, but since they have names the unused-mut lint thinks that it should check them.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    333d8c4 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#52821 - fukatani:gdb-vecdeque-print, r=mich…

    …aelwoerister
    
    pretty print for std::collections::vecdeque
    
    I want pretty print function for VecDeque like Vec.
    
    ```rust
    use std::collections::VecDeque;
    
    fn main() {
        let mut d: VecDeque<i32> = VecDeque::new();
        d.push_back(4);
        d.push_back(4);
        d.push_back(6);
        let mut v: Vec<i32> = Vec::new();
        v.push(4);
        v.push(4);
        v.push(6);
    }
    ```
    
    ```
    (gdb) p v
    $1 = Vec<i32>(len: 3, cap: 4) = {4, 4, 6}
    (gdb) p d
    $2 = VecDeque<i32>(len: 3, cap: 8) = {4, 4, 6}
    ```
    
    Thanks.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    39406ee View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#52822 - MajorBreakfast:fix-from-local-waker…

    …, r=cramertj
    
    Fix From<LocalWaker>
    
    This is a follow-up to rust-lang#52640
    
    Fixes `From<LocalWaker>` which is affected by the same accidental drop bug (unless I'm totally mistaken)
    
    r? @cramertj
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    9e43ebd View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#52824 - varkor:fix-llvm-ret-move-warnings, …

    …r=rkruppe
    
    Fix -Wpessimizing-move warnings in rustllvm/PassWrapper
    
    These are producing warnings when building rustc (`warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]`).
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    61b9a51 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#52825 - RalfJung:codegen, r=alexcrichton

    Make sure rust-lang#47772 does not regress
    
    Mostly to make my life in rust-lang#52206 harder.^^
    
    Or should I just add that test there?
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    fe4358a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#52831 - dsciarra:rm-ref-to-author-file, r=a…

    …lexcrichton
    
    remove references to AUTHORS.txt file
    
    Rust does not ship an AUTHORS.txt file anymore.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    8b31f00 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a819a6c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#52846 - kennytm:bootstrap-curl-timeout, r=M…

    …ark-Simulacrum
    
    Add timeout to use of `curl` in bootstrap.py.
    
    Recently we've seen a lot of "30 minutes no output" spurious errors while downloading the bootstrap compiler. This added several timeout options so if the "30 minutes no output" errors were caused by connection or transfer issue, we could fail quicker for curl to retry.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    c9aca03 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#52851 - flip1995:tool_lints, r=oli-obk

    Make the tool_lints actually usable
    
    cc rust-lang#44690
    
    Necessary for rust-lang/rust-clippy#2955 and rust-lang/rust-clippy#2977
    
    This PR makes it possible for lint tools (at the moment only for Clippy) to implement the `tool_lints`, like it was documented in rust-lang#52018.
    
    Because the `declare_lint` macro is pretty cluttered right now, there was not really a good way to add the `tool_name` as an additional argument of the macro. That's why I chose to introduce the new `declare_tool_lint` macro.
    
    The switch from `&str` to `String` in the `lint_groups` `FxHashMap` is because I got weird error messages in the `check_lint_name` method. And the `by_name` field of the `LintStore` also uses `String`.
    
    ### What comes with this PR:
    
    If this PR lands and Clippy switches to the `tool_lints`, the currently used methods
    ```rust
    #[cfg_attr(feature = "cargo-clippy", allow(clippy_lint))]
    #[allow(unknown_lints, clippy_lint)]
    ```
    to `allow`/`warn`/`deny`/`forbid` Clippy lints, won't have any effects anymore, but also won't produce a warning. That is because the name of `clippy_lint` will then be `clippy::clippy_lint`. (Maybe we can add a clippy lint to search for `cfg_attr` appearances with the `cargo-clippy` feature?)
    
    r? @oli-obk
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    5fb7c65 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#52853 - RalfJung:bootstrap-help, r=alexcric…

    …hton
    
    Improve bootstrap help on stages
    
    Cc @eddyb
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    6767886 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#52859 - ljedrz:smallvec_true_extend, r=Mark…

    …-Simulacrum
    
    Use Vec::extend in SmallVec::extend when applicable
    
    As calculated in rust-lang#52738, `Vec::extend` is much faster than `push`ing to it in a loop. We can take advantage of this method in `SmallVec` too - at least in cases when its underlying object is an `AccumulateVec::Heap`.
    
    ~~This approach also accidentally improves the `push` loop of the `AccumulateVec::Array` variant, because it doesn't utilize `SmallVec::push` which performs `self.reserve(1)` with every iteration; this is unnecessary, because we're already reserving the whole space we will be needing by performing `self.reserve(iter.size_hint().0)` at the beginning.~~
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    eb71c35 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#52861 - ColinFinck:master, r=alexcrichton

    Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.
    
    As a start, the port uses the simplest possible configuration (no jemalloc, abort on panic) and makes use of existing Unix-specific code wherever possible.
    It adds targets for x86_64 (current main HermitCore platform) and aarch64 (HermitCore platform under development).
    
    Together with the patches to "liblibc" (rust-lang/libc#1048) and llvm (rust-lang/llvm#122), this enables HermitCore applications to be written in Rust.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    f47a764 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#52867 - matthiaskrgr:release_typos, r=Mark-…

    …Simulacrum
    
    releases.md: fix 2 typos
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    51e744b View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#52870 - cramertj:unpin-futureobj, r=aturon

    Implement Unpin for FutureObj and LocalFutureObj
    
    cc @MajorBreakfast
    
    r? @aturon
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    341f882 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#52876 - cuviper:const-endianness-be, r=kennytm

    run-pass/const-endianness: negate before to_le()
    
    `const LE_I128` needs parentheses to negate the value *before* calling
    `to_le()`, otherwise it doesn't match the operations performed in the
    black-boxed part of the test.  This only makes a tangible difference on
    big-endian targets.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    b3d6050 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#52878 - mikhail-m1:master, r=kennytm

    Fix wrong issue number in the test name
    
    I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113
    
    r? @kennytm
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    9443dd5 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#52883 - estebank:nll-diag-mut, r=oli-obk

    Include lifetime in mutability suggestion in NLL messages
    
    Fix rust-lang#52880.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    312f18c View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#52888 - estebank:shell-sugg, r=oli-obk

    Use suggestions for shell format arguments
    
    Follow up to rust-lang#52649.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    a8ed603 View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#52904 - pnkfelix:issue-51167-sort-by-span, …

    …r=petrochenkov
    
    NLL: sort diagnostics by span
    
    Sorting the output diagnostics by span is a long planned revision to the NLL diagnostics that we hope will yield a less surprising user experience in some case.
    
    Once we got them buffered, it was trivial to implement. (The hard part is skimming the resulting changes to the diagnostics to make sure nothing broke... Note that I largely rubber-stamped the `#[rustc_regions]` output change.)
    
    Fix rust-lang#51167
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    2d29c44 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#52905 - pravic:unsize-typo, r=alexcrichton

    Fix a typo in unsize.rs
    
    RfC -> RFC
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    ac2b3c3 View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#52907 - pnkfelix:issue-52877-original-sourc…

    …e-should-precede-suggestions, r=petrochenkov
    
    NLL: On "cannot move out of type" error, print original before rewrite
    
    NLL: On "cannot move out of type" error, print original source before rewrite.
    
     * Arguably this change is sometimes injecting noise into the output  (namely in the cases where the suggested rewrite is inline with the   suggestion and we end up highlighting the original source code).   I would not be opposed to something more aggressive/dynamic, like   revising the suggestion code to automatically print the original  source when necessary (e.g. when the error does not have a span   that includes the span of the suggestion).
    
     * Also, as another note on this change: The doc comment for `Diagnostic::span_suggestion`  says:
    ```rust
        /// The message
        ///
        /// * should not end in any punctuation (a `:` is added automatically)
        /// * should not be a question
        /// * should not contain any parts like "the following", "as shown"
    ```
      *  but the `:` is *not* added when the emitted line appears  out-of-line relative to the suggestion. I find that to be an  unfortunate UI experience.
    
    ----
    
    As a drive-by fix, also changed code to combine multiple suggestions for a pattern into a single multipart suggestion (which vastly improves user experience IMO).
    
    ----
    
    Includes the updates to expected NLL diagnostics.
    
    Fix rust-lang#52877
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    14546cd View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#52914 - nagisa:sparc-is-sparc’s-own-busines…

    …s, r=alexcrichton
    
    Only run the sparc-abi test on sparc
    
    It is not required for LLVM to have SPARC target support, so it is
    necessary to only run this test when LLVM does support SPARC. Sadly, it
    isn’t possible to specify exactly this constraint. Instead, we specify
    that this test should run on SPARC host only (it surely is sane
    assumption to make that compiler running on a SPARC can generate
    SPARC, right?)
    
    Since you cannot specify multiple `only-*` to have it run on both 32-bit
    and 64-bit SPARC we pick 64-bit SPARC, because it is exactly what is
    being tested by this test.
    
    Fixes rust-lang#52881
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    52b52f3 View commit details
    Browse the repository at this point in the history
  30. Rollup merge of rust-lang#52918 - pietroalbini:1.27.2-notes, r=Mark-S…

    …imulacrum
    
    Backport 1.27.2 release notes
    
    r? @Mark-Simulacrum
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    7759199 View commit details
    Browse the repository at this point in the history
  31. Rollup merge of rust-lang#52929 - Havvy:patch-1, r=alexcrichton

    Update compatibility note for 1.28.0 to be correct
    
    You can still put implementations on `dyn Trait + Send + Send`, but it'd be the same as putting them on `dyn Trait + Send`. This is why the error is that there are duplicate definitions in the example.
    pietroalbini authored Aug 1, 2018
    Configuration menu
    Copy the full SHA
    850b613 View commit details
    Browse the repository at this point in the history