-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize macro_vis_matcher #53370
Stabilize macro_vis_matcher #53370
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r? @cramertj |
@@ -25,7 +25,6 @@ | |||
#![feature(unsize)] | |||
#![feature(specialization)] | |||
#![feature(optin_builtin_traits)] | |||
#![feature(macro_vis_matcher)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than removing these feature gates, they need to be changed to #![cfg_attr(stage0, feature(macro_vis_matcher))]
so that the old compiler can compile current the current rustc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duh, reading comprehension is not my strong suit apparently. Hopefully fixed up now, let's see what CI says
@cramertj should be better now :) |
8c13b3f
to
00920c0
Compare
@bors r+ |
📌 Commit 00920c0 has been approved by |
…her, r=cramertj Stabilize macro_vis_matcher This PR should stabilize [macro_vis_matcher](rust-lang#41022) feature. - [ ] "reference" book changes: rust-lang/reference#400 - [ ] "Rust by example" book changes: rust-lang/rust-by-example#1096 - [ ] "clippy" changes: rust-lang/rust-clippy#3055 r? @cramertj
Rollup of 17 pull requests Successful merges: - #53030 (Updated RELEASES.md for 1.29.0) - #53104 (expand the documentation on the `Unpin` trait) - #53213 (Stabilize IP associated constants) - #53296 (When closure with no arguments was expected, suggest wrapping) - #53329 (Replace usages of ptr::offset with ptr::{add,sub}.) - #53363 (add individual docs to `core::num::NonZero*`) - #53370 (Stabilize macro_vis_matcher) - #53393 (Mark libserialize functions as inline) - #53405 (restore the page title after escaping out of a search) - #53452 (Change target triple used to check for lldb in build-manifest) - #53462 (Document Box::into_raw returns non-null ptr) - #53465 (Remove LinkMeta struct) - #53492 (update lld submodule to include RISCV patch) - #53496 (Fix typos found by codespell.) - #53521 (syntax: Optimize some literal parsing) - #53540 (Moved issue-53157.rs into src/test/ui/consts/const-eval/) - #53551 (Avoid some Place clones.) Failed merges: r? @ghost
@@ -648,6 +645,8 @@ declare_features! ( | |||
(accepted, repr_transparent, "1.28.0", Some(43036), None), | |||
// Defining procedural macros in `proc-macro` crates | |||
(accepted, proc_macro, "1.29.0", Some(38356), None), | |||
// Allows use of the :vis macro fragment specifier | |||
(accepted, macro_vis_matcher, "1.29.0", Some(41022), None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 1.30.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry: I wondered about this after rebasing on top of master, but forge instructions said to look at forge for the next stable and that was 1.29.
Shall I send a PR to fix this up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging reviewer: @cramertj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure-- a PR to bump the version number would be appreciated 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing this the first time around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should stabilize macro_vis_matcher feature.
r? @cramertj