-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize macro_vis_matcher #53370
Stabilize macro_vis_matcher #53370
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -342,9 +342,6 @@ declare_features! ( | |
// Allows overlapping impls of marker traits | ||
(active, overlapping_marker_traits, "1.18.0", Some(29864), None), | ||
|
||
// Allows use of the :vis macro fragment specifier | ||
(active, macro_vis_matcher, "1.18.0", Some(41022), None), | ||
|
||
// rustc internal | ||
(active, abi_thiscall, "1.19.0", None, None), | ||
|
||
|
@@ -648,6 +645,8 @@ declare_features! ( | |
(accepted, repr_transparent, "1.28.0", Some(43036), None), | ||
// Defining procedural macros in `proc-macro` crates | ||
(accepted, proc_macro, "1.29.0", Some(38356), None), | ||
// Allows use of the :vis macro fragment specifier | ||
(accepted, macro_vis_matcher, "1.29.0", Some(41022), None), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops sorry: I wondered about this after rebasing on top of master, but forge instructions said to look at forge for the next stable and that was 1.29. Shall I send a PR to fix this up? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pinging reviewer: @cramertj There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure-- a PR to bump the version number would be appreciated 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry for missing this the first time around. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
// Allows importing and reexporting macros with `use`, | ||
// enables macro modularization in general. | ||
(accepted, use_extern_macros, "1.30.0", Some(35896), None), | ||
|
@@ -1363,9 +1362,6 @@ pub const EXPLAIN_DEPR_CUSTOM_DERIVE: &'static str = | |
pub const EXPLAIN_DERIVE_UNDERSCORE: &'static str = | ||
"attributes of the form `#[derive_*]` are reserved for the compiler"; | ||
|
||
pub const EXPLAIN_VIS_MATCHER: &'static str = | ||
":vis fragment specifier is experimental and subject to change"; | ||
|
||
pub const EXPLAIN_LITERAL_MATCHER: &'static str = | ||
":literal fragment specifier is experimental and subject to change"; | ||
|
||
|
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than removing these feature gates, they need to be changed to
#![cfg_attr(stage0, feature(macro_vis_matcher))]
so that the old compiler can compile current the current rustc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duh, reading comprehension is not my strong suit apparently. Hopefully fixed up now, let's see what CI says