Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment ext::tt::transcribe #60618

Merged
merged 4 commits into from
May 10, 2019
Merged

Comment ext::tt::transcribe #60618

merged 4 commits into from
May 10, 2019

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented May 7, 2019

Also did a bit of minor cleanup (remove unidiomatic use of Add and an unneeded clone). No functionality changes.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2019
Centril
Centril reviewed May 7, 2019
View reviewed changes
src/libsyntax/ext/tt/transcribe.rs Outdated Show resolved Hide resolved
src/libsyntax/ext/tt/transcribe.rs Outdated Show resolved Hide resolved
@mark-i-m mark-i-m mentioned this pull request May 7, 2019
Merged
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:07d2fecc:start=1557270259665799738,finish=1557270346337693066,duration=86671893328
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:26:11]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:26:11]    Compiling libc v0.2.54
[00:26:11]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:26:12]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:26:12] thread 'rustc' panicked at 'assertion failed: src.len() > 0', src/libsyntax/ext/tt/transcribe.rs:74:5
[00:26:12] 
[00:26:12] error: internal compiler error: unexpected panic
[00:26:12] 
[00:26:12] note: the compiler unexpectedly panicked. this is a bug.
[00:26:12] note: the compiler unexpectedly panicked. this is a bug.
[00:26:12] 
[00:26:12] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:26:12] 
[00:26:12] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[00:26:12] 
[00:26:12] note: compiler flags: -Z external-macro-backtrace -Z unstable-options -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C codegen-units=1 -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:26:12] note: some of the compiler flags provided by cargo are hidden
[00:26:12] 
[00:26:12] error: Could not compile `core`.
[00:26:12] warning: build failed, waiting for other jobs to finish...

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@mark-i-m
Copy link
Member Author

mark-i-m commented May 9, 2019

@jseyfried If you have any feedback here, that would be appreciated too.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2019

📌 Commit eb7d47c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2019
Centril added a commit to Centril/rust that referenced this pull request May 9, 2019
@Centril
Rollup merge of rust-lang#60618 - mark-i-m:transcribe, r=petrochenkov
903fc4b 
Comment ext::tt::transcribe

Also did a bit of minor cleanup (remove unidiomatic use of `Add` and an unneeded `clone`). No functionality changes.

r? @petrochenkov
@Centril Centril mentioned this pull request May 9, 2019
Merged
bors added a commit that referenced this pull request May 10, 2019
@bors
Auto merge of #60683 - Centril:rollup-p05qh5d, r=Centril
03bd2f6 
Rollup of 8 pull requests

Successful merges:

 - #59348 (Clean up and add tests for slice drop shims)
 - #60188 (Identify when a stmt could have been parsed as an expr)
 - #60234 (std: Derive `Default` for `io::Cursor`)
 - #60618 (Comment ext::tt::transcribe)
 - #60648 (Skip codegen for one UI test with long file path)
 - #60671 (remove unneeded `extern crate`s from build tools)
 - #60675 (Remove the old await! macro)
 - #60676 (Fix async desugaring providing wrong input to procedural macros.)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 10, 2019

⌛ Testing commit eb7d47c with merge 03bd2f6...

@bors bors merged commit eb7d47c into rust-lang:master May 10, 2019
@mark-i-m mark-i-m deleted the transcribe branch May 25, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mark-i-m @rust-highfive @petrochenkov @bors @Centril