Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of FIXMEs in ext::tt::transcribe #60620

Merged
merged 1 commit into from
May 10, 2019
Merged

Fix a couple of FIXMEs in ext::tt::transcribe #60620

merged 1 commit into from
May 10, 2019

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented May 7, 2019

Blocked on #60618

A crater run would be nice to make sure my understanding is correct. A quick google search seems to indicate these are extremely rare errors if they are possible (which I don't believe they are).

r? @petrochenkov

cc #2887 (there is only one FIXME left and it is hygiene-related)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:22c62a1a:start=1557270611248650305,finish=1557270699296880999,duration=88048230694
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:28:03]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:28:03]    Compiling libc v0.2.54
[00:28:03]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:28:04]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:28:04] thread 'rustc' panicked at 'assertion failed: src.len() > 0', src/libsyntax/ext/tt/transcribe.rs:74:5
[00:28:04] 
[00:28:04] error: internal compiler error: unexpected panic
[00:28:04] 
[00:28:04] note: the compiler unexpectedly panicked. this is a bug.
[00:28:04] note: the compiler unexpectedly panicked. this is a bug.
[00:28:04] 
[00:28:04] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[00:28:04] 
[00:28:04] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[00:28:04] 
[00:28:04] note: compiler flags: -Z external-macro-backtrace -Z unstable-options -Z force-unstable-if-unmarked -C opt-level=2 -C prefer-dynamic -C debug-assertions=y -C codegen-units=1 -C link-args=-Wl,-rpath,$ORIGIN/../lib --crate-type lib
[00:28:04] note: some of the compiler flags provided by cargo are hidden
[00:28:04] 
[00:28:04] error: Could not compile `core`.
[00:28:04] warning: build failed, waiting for other jobs to finish...

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@mark-i-m mark-i-m mentioned this pull request May 7, 2019
Closed
@petrochenkov
Copy link
Contributor

@bors try (for crater)

@bors
Copy link
Contributor

bors commented May 9, 2019

⌛ Trying commit 59019a5cfc94833d32354c0fd83385c67da1b78c with merge a7cff45e655f886da150e206c7acbe984df4ab71...

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2019
@bors
Copy link
Contributor

bors commented May 9, 2019

☀️ Try build successful - checks-travis
Build commit: a7cff45e655f886da150e206c7acbe984df4ab71

@petrochenkov
Copy link
Contributor

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-60620 created and queued.
🤖 Automatically detected try build a7cff45e655f886da150e206c7acbe984df4ab71
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-60620 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-60620 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member

@craterbot retry

Wut docker died.

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-60620 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-60620 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-60620 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@mark-i-m
Copy link
Member Author

Completed jobs: 98346 / 98348

😢

@pietroalbini
Copy link
Member

What is happening with this agent :/

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-60620 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-60620 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-60620 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 10, 2019
@pietroalbini
Copy link
Member

Whelp that run completly broke (no successful tests...).

@craterbot run mode=check-only assign=agent:aws-2

@craterbot
Copy link
Collaborator

👌 Experiment pr-60620-1 created and queued.
🤖 Automatically detected try build a7cff45e655f886da150e206c7acbe984df4ab71
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2019
@craterbot
Copy link
Collaborator

🎉 Experiment pr-60620-1 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 10, 2019
@petrochenkov
Copy link
Contributor

Unless this PR is useful as a testing ground for crater, I'd suggest to just land it and revert with tests if it turns out that the code hitting these ICEs is possible, there's plenty of time to do that (there are also regular beta crater runs).

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2019
@mark-i-m
Copy link
Member Author

@petrochenkov Sure, it looks like there were no regressions, which is expected. I can rebase the PR and it will be ready to be merged. @pietroalbini do you want me to wait?

@pietroalbini
Copy link
Member

I haven't had time to investigate this yet, but I don't need this PR to be open to be able to do that (the try builds are already uploaded).

@mark-i-m
Copy link
Member Author

@pietroalbini Ok, thanks :) @petrochenkov I rebased.

@petrochenkov
Copy link
Contributor

it looks like there were no regressions

That's because crater is broken.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2019

📌 Commit 5b6bda3 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2019
@pietroalbini
Copy link
Member

@mark-i-m @petrochenkov I found the crater bug and I should have a patch deployed in max a few hours. Do you want to r-?

@mark-i-m
Copy link
Member Author

@petrochenkov Ah I see. I'm fine with waiting for the crater run if you want... This PR is not super-high priority. These FIXMEs have been around for ~7 years IIUC...

@pietroalbini
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2019
@pietroalbini
Copy link
Member

@bors r=petrochenkov rollup

This will likely require more time to fully investigate since Cargo changed how its internal locking works, conflicting with Crater wanting to make as much stuff as possible read-only.

@bors
Copy link
Contributor

bors commented May 10, 2019

📌 Commit 5b6bda3 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2019
Centril added a commit to Centril/rust that referenced this pull request May 10, 2019
@Centril
Rollup merge of rust-lang#60620 - mark-i-m:transcribe-2, r=petrochenkov
20dff29 
Fix a couple of FIXMEs in ext::tt::transcribe

_Blocked on #60618_

A crater run would be nice to make sure my understanding is correct. A quick google search seems to indicate these are extremely rare errors if they are possible (which I don't believe they are).

r? @petrochenkov

cc rust-lang#2887 (there is only one FIXME left and it is hygiene-related)
@Centril Centril mentioned this pull request May 10, 2019
Merged
bors added a commit that referenced this pull request May 10, 2019
@bors
Auto merge of #60708 - Centril:rollup-j5smdo0, r=Centril
d595b11 
Rollup of 6 pull requests

Successful merges:

 - #60529 (RFC 2008: Uninhabitedness fixes for enum variants and tests)
 - #60620 (Fix a couple of FIXMEs in ext::tt::transcribe)
 - #60659 (Tweak `Symbol` and `InternedString`)
 - #60692 (Extend #60676 test for nested mut patterns.)
 - #60697 (add regression test for #60629)
 - #60701 (Update mailmap for mati865)

Failed merges:

r? @ghost
@bors bors merged commit 5b6bda3 into rust-lang:master May 10, 2019
@oli-obk oli-obk mentioned this pull request May 22, 2019
Closed
@mark-i-m mark-i-m deleted the transcribe-2 branch May 25, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mark-i-m @rust-highfive @petrochenkov @bors @craterbot @pietroalbini