Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Rollup backports #63771

Merged
merged 5 commits into from
Aug 21, 2019
Merged

[beta] Rollup backports #63771

merged 5 commits into from
Aug 21, 2019

Conversation

pietroalbini
Copy link
Member

Cherry-picked:

r? @ghost

andersk and others added 5 commits August 21, 2019 08:50
The slash and quotes in ?/“Kleene” appeared to define “Kleene” as the
name for the ? operator, which is not the case.  Rust has three Kleene
operators *, +, ?.

(Pointed out by /u/Sharlinator on Reddit.)

Signed-off-by: Anders Kaseorg <[email protected]>
Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with
CI toolchains. This is problematic for multiple reasons:

- CI IAM credentials are allowed to both edit and delete those files.
  A malicious user gaining access to those credentials would be able to
  change our mirrored dependencies, possibly backdooring the compiler.

- Contents of the rust-lang-ci2 bucket are disposable except for the
  mirrors' content. When we implement backups for S3 buckets we'd have
  to replicate just that part of the bucket, complicating the backup
  logic and increasing the chance of mistakes. A standalone bucket will
  be way easier to backup.

This commit switches our CI to use the new rust-lang-ci-mirrors bucket.
@pietroalbini
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Aug 21, 2019

📌 Commit 3288766 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 21, 2019
@bors
Copy link
Contributor

bors commented Aug 21, 2019

⌛ Testing commit 3288766 with merge 641586c...

bors added a commit that referenced this pull request Aug 21, 2019
[beta] Rollup backports

Cherry-picked:

*  RELEASES.md: ? is one of three Kleene operators #63529
*  Do not ICE when synthesizing spans falling inside unicode chars #63508
*  ci: move mirrors to their standalone bucket #63485

r? @ghost
@bors
Copy link
Contributor

bors commented Aug 21, 2019

☀️ Test successful - checks-azure
Approved by: pietroalbini
Pushing 641586c to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2019
@bors bors merged commit 3288766 into rust-lang:beta Aug 21, 2019
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants