Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Rollup backports #63771

Merged
merged 5 commits into from
Aug 21, 2019
Merged

[beta] Rollup backports #63771

merged 5 commits into from
Aug 21, 2019

Commits on Aug 21, 2019

  1. RELEASES.md: ? is one of three Kleene operators 

    The slash and quotes in ?/“Kleene” appeared to define “Kleene” as the
name for the ? operator, which is not the case.  Rust has three Kleene
operators *, +, ?.

(Pointed out by /u/Sharlinator on Reddit.)

Signed-off-by: Anders Kaseorg <[email protected]>
    @andersk @pietroalbini
    andersk authored and pietroalbini committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    539db81 View commit details
    Browse the repository at this point in the history

  2. Do not ICE when synthesizing spans falling inside unicode chars

    @estebank @pietroalbini
    estebank authored and pietroalbini committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    10d6521 View commit details
    Browse the repository at this point in the history

  3. review comment: remove unecessary error in test

    @estebank @pietroalbini
    estebank authored and pietroalbini committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    bcd353c View commit details
    Browse the repository at this point in the history

  4. review comments

    @estebank @pietroalbini
    estebank authored and pietroalbini committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    2d2448b View commit details
    Browse the repository at this point in the history

  5. ci: move mirrors to their standalone bucket 

    Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with
CI toolchains. This is problematic for multiple reasons:

- CI IAM credentials are allowed to both edit and delete those files.
  A malicious user gaining access to those credentials would be able to
  change our mirrored dependencies, possibly backdooring the compiler.

- Contents of the rust-lang-ci2 bucket are disposable except for the
  mirrors' content. When we implement backups for S3 buckets we'd have
  to replicate just that part of the bucket, complicating the backup
  logic and increasing the chance of mistakes. A standalone bucket will
  be way easier to backup.

This commit switches our CI to use the new rust-lang-ci-mirrors bucket.
    @pietroalbini
    pietroalbini committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    3288766 View commit details
    Browse the repository at this point in the history