Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #64637

Closed
wants to merge 25 commits into from
Closed

Commits on Sep 13, 2019

  1. Configuration menu
    Copy the full SHA
    612ef5f View commit details
    Browse the repository at this point in the history
  2. change to check-pass

    nikomatsakis committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    e69d1b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Document From trait for LhsExpr

    crgl committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    194d357 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Configuration menu
    Copy the full SHA
    3f004a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Configuration menu
    Copy the full SHA
    c57e8eb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf4bc7d View commit details
    Browse the repository at this point in the history
  3. Add more tests

    weiznich committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    a9c38d9 View commit details
    Browse the repository at this point in the history
  4. Split line to fix tidy

    weiznich committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    31b3012 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Address review comments.

    crlf0710 committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    6e9c0b0 View commit details
    Browse the repository at this point in the history
  2. rustbuild: Turn down compression on exe installers

    The Windows dist builders are the slowest builders right now, and the
    distribution phase of them is enormously slow clocking in at around 20
    minutes to build all the related installers. This commit starts to
    optimize these by turning down the compression level in the `exe`
    installers. These aren't super heavily used so there's no great need for
    them to be so ultra-compressed, so let's dial back the compression
    parameters to get closer to the rest of our xz archives. This brings the
    installer in line with the gz tarball installer locally, and also brings
    the compression settings on par with the rest of our xz installers.
    alexcrichton committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    8112f71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ab5593 View commit details
    Browse the repository at this point in the history
  4. rustbuild: Turn down compression on msi installers

    This is the same as rust-lang#64615 except applied to our MSI installers. The
    same fix is applied effectively bringing these installers in line with
    the gz tarball installers, which are about 3x faster to produce locally
    and likely much faster to produce on CI.
    alexcrichton committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    fde8cfe View commit details
    Browse the repository at this point in the history
  5. rustbuild: Improve output of dist step

    * Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
      output about compressing documentation.
    * Print out what's happening before long steps
    * Use `timeit` to print out timing information for long-running
      installer assemblies.
    alexcrichton committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    255dd3f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3db2c13 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Configuration menu
    Copy the full SHA
    9846af8 View commit details
    Browse the repository at this point in the history
  2. remove the extra comma after the match arm

    This would follow the same coding style as all the other match arms in this file.
    guanqun authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    c3140ba View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#63948 - crlf0710:path_to_raw_dylib, r=Centril

    Add feature gate for raw_dylib.
    
    This PR adds the feature gate for RFC 2627 (rust-lang#58713). It doesn't contain the actual functionality.
    Add I'm not sure whether i did it correctly, since this is the first time i did this.
    
    r? @Centril
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    3d9fd95 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#64136 - crgl:doc-from-parser-lhs, r=Centril

    Document From trait for LhsExpr in parser
    
    Add doc for From trait for converting P<Expr> and Option<ThinVec<Attribute>> to LhsExpr
    
    As part of issue rust-lang#51430 (cc @skade).
    
    Both of these should just be moving an address and setting a discriminant in an enum. The main thing I'm not sure about is whether it's worth documenting the branch in the From<Option<ThinVec<Attribute>>. As far as I can tell it doesn't seem like it is optimized away (although if the discriminant happened to work out you could just copy the pointer and the discriminant which might be cheaper, but that's not guaranteed). So it seems like if it's being called often, it's doubling the number of possible branch mispredictions on this Option, which could be a significant cost.
    
    Let me know if there's anything that needs fixing and I'll get to it as soon as possible!
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    655f347 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#64342 - glorv:master, r=varkor

    factor out pluralisation remains after rust-lang#64280
    
    there are two case that doesn't not match the original macro pattern at [here](https://github.com/rust-lang/rust/blob/master/src/librustc_lint/unused.rs#L146) and [here](https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/diagnostics.rs#L539) as the provided param is already a bool or the check condition is not `x != 1`, so I change the macro accept a boolean expr instead of number to fit all the cases.
    
    @Centril  please review
    
    Fixes rust-lang#64238.
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    d26540b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#64546 - weiznich:bugfix/rfc-2451-rerebalanc…

    …e-tests, r=nikomatsakis
    
    Bugfix/rfc 2451 rerebalance tests
    
    r? @nikomatsakis
    
    Fixes rust-lang#64412
    Depends/Contains on rust-lang#64414
    
    cc rust-lang#55437 and rust-lang#63599
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    3412d4f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#64615 - alexcrichton:smaller-exe, r=Mark-Si…

    …mulacrum
    
    rustbuild: Turn down compression on exe installers
    
    The Windows dist builders are the slowest builders right now, and the
    distribution phase of them is enormously slow clocking in at around 20
    minutes to build all the related installers. This commit starts to
    optimize these by turning down the compression level in the `exe`
    installers. These aren't super heavily used so there's no great need for
    them to be so ultra-compressed, so let's dial back the compression
    parameters to get closer to the rest of our xz archives. This brings the
    installer in line with the gz tarball installer locally, and also brings
    the compression settings on par with the rest of our xz installers.
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    787f862 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#64617 - alexcrichton:smaller-msi, r=Mark-Si…

    …mulacrum
    
    rustbuild: Turn down compression on msi installers
    
    This is the same as rust-lang#64615 except applied to our MSI installers. The
    same fix is applied effectively bringing these installers in line with
    the gz tarball installers, which are about 3x faster to produce locally
    and likely much faster to produce on CI.
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    60da439 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…

    …=Mark-Simulacrum
    
    rustbuild: Improve output of `dist` step
    
    * Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
      output about compressing documentation.
    * Print out what's happening before long steps
    * Use `timeit` to print out timing information for long-running
      installer assemblies.
    * Try to scope output of `Dist ...` to not also encompass actual build steps
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    4a75154 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3f4f41d View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#64632 - guanqun:patch-1, r=jonas-schievink

    remove the extra comma after the match arm
    
    This would follow the same coding style as all the other match arms in this file.
    Centril authored Sep 20, 2019
    Configuration menu
    Copy the full SHA
    ae5d53d View commit details
    Browse the repository at this point in the history