Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove as_str if the type is already &str #64739

Merged
merged 6 commits into from
Oct 7, 2019
Merged

Remove as_str if the type is already &str #64739

merged 6 commits into from
Oct 7, 2019

Conversation

guanqun
Copy link
Contributor

@guanqun guanqun commented Sep 24, 2019 •
edited
Loading

Fix #62642

r? @estebank

do you think the suggestion tip is good enough?

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2019
@guanqun guanqun changed the title Remove as str Remove as_str if the type is already &str Sep 24, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@guanqun
Copy link
Contributor Author

guanqun commented Oct 6, 2019

@estebank could you please help review again? thanks.

@estebank
Copy link
Contributor

estebank commented Oct 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit 11c2d43 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2019
@bors
Copy link
Contributor

bors commented Oct 7, 2019

⌛ Testing commit 11c2d43 with merge 979ebea959f8849f965073bc6ffe786fac4bdd67...

Centril added a commit to Centril/rust that referenced this pull request Oct 7, 2019
@Centril
Rollup merge of rust-lang#64739 - guanqun:remove-as-str, r=estebank
c100831 
Remove as_str if the type is already &str

Fix rust-lang#62642

r? @estebank

do you think the suggestion tip is good enough?
@Centril Centril mentioned this pull request Oct 7, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Oct 7, 2019

@bors retry rolled up.

@bors
Copy link
Contributor

bors commented Oct 7, 2019

⌛ Testing commit 11c2d43 with merge f92f3c4...

bors added a commit that referenced this pull request Oct 7, 2019
@bors
Auto merge of #64739 - guanqun:remove-as-str, r=estebank
f92f3c4 
Remove as_str if the type is already &str

Fix #62642

r? @estebank

do you think the suggestion tip is good enough?
@bors
Copy link
Contributor

bors commented Oct 7, 2019

☀️ Test successful - checks-azure
Approved by: estebank
Pushing f92f3c4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 7, 2019
@bors bors merged commit 11c2d43 into rust-lang:master Oct 7, 2019
@guanqun guanqun deleted the remove-as-str branch October 7, 2019 09:34
@estebank estebank mentioned this pull request Oct 7, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
@Centril
Rollup merge of rust-lang#65194 - estebank:remove_str, r=petrochenkov
4a6304f 
Use structured suggestion for removal of `as_str()` call

Follow up to rust-lang#64739.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@Centril Centril Centril left review comments

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest removal of .as_str() when called on a &str
6 participants
@guanqun @rust-highfive @estebank @bors @Centril @oli-obk