Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove as_str if the type is already &str #64739

Merged
merged 6 commits into from
Oct 7, 2019
Merged

Remove as_str if the type is already &str #64739

merged 6 commits into from
Oct 7, 2019

Commits on Oct 2, 2019

  1. remove 'as_str' when it's already a str type. 

    fix rust-lang#62642
    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    a5d9310 View commit details
    Browse the repository at this point in the history

  2. add test files

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    bb3c030 View commit details
    Browse the repository at this point in the history

  3. comment fixes

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    4cb86c9 View commit details
    Browse the repository at this point in the history

  4. add FIXME and use 'span_label'

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    5abc5e9 View commit details
    Browse the repository at this point in the history

  5. fix unit tests

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    51482d0 View commit details
    Browse the repository at this point in the history

  6. typo fix in the code

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    11c2d43 View commit details
    Browse the repository at this point in the history