Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #67505

Merged
merged 51 commits into from
Dec 22, 2019
Merged

Rollup of 6 pull requests #67505

merged 51 commits into from
Dec 22, 2019

Commits on Dec 18, 2019

  1. Configuration menu
    Copy the full SHA
    44603a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Configuration menu
    Copy the full SHA
    3a93a0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d99e4e View commit details
    Browse the repository at this point in the history
  3. lower_pattern_unadjusted: remove dead code.

    The code is dead because `check_pat_slice` will never have
    `expected = ty::Ref(...)` due to default-binding-modes
    (see `is_non_ref_pat`, `peel_off_references`).
    
    Moreover, if the type is not `ty::Array(_) | ty::Slice(_)`
    then `check_pat_slice` enters an error branch.
    Centril committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    13b7101 View commit details
    Browse the repository at this point in the history
  4. check_pat_slice: extract check_aray_pat_len.

    Also use `types.err` when matching on `expected.kind`s
    which don't match `ty::Array(..) | ty::Slice(_)`.
    Centril committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    ceaec1d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2a9f1f8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3b0af1d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    be6381e View commit details
    Browse the repository at this point in the history
  8. lower_pattern_unadjusted: simplify Binding(..) branch.

    Avoid calling `.node_type(...)` again.
    Centril committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    eb020bc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d63c324 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cc3160b View commit details
    Browse the repository at this point in the history
  11. slice_or_array_pattern: remove dead code.

    After rust-lang#62550, it is no longer possible for `slice`
    to be other than `None | Some(Binding(..) | Wild)`.
    In particular, `lower_pat_slice` may never generate
    `Some(Array(..) | Slice(..))` and so there is nothing
    to flatten into `slice`.
    Centril committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    6286a1d View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. SliceKind::VarLen: make doc-comment render correctly.

    (The backticks were rendering badly in VSCode.)
    Centril committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    7353ff2 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. Configuration menu
    Copy the full SHA
    f7256d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3ef4a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c67c30d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3838b60 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    211560d View commit details
    Browse the repository at this point in the history
  6. extract parse_typeof_ty

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    e08886d View commit details
    Browse the repository at this point in the history
  7. extract parse_impl_ty

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    edb7b96 View commit details
    Browse the repository at this point in the history
  8. extract parse_dyn_ty

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    b7071f2 View commit details
    Browse the repository at this point in the history
  9. extract parse_path_start_ty

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    85d3ed9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6f1f6a6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3b1fab8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3f499a9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b484fae View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a11252a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e61cb44 View commit details
    Browse the repository at this point in the history
  16. extract can_begin_bound

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    fd89104 View commit details
    Browse the repository at this point in the history
  17. extract parse_generic_bound

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    8a9a992 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    18e5b2f View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    1cfeb56 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    50e00c7 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    4b073a1 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    f215ca9 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    4625ba4 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    b5f00be View commit details
    Browse the repository at this point in the history
  25. extract error_negative_bounds

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    f221b39 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    d010560 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    d6f37c6 View commit details
    Browse the repository at this point in the history
  28. unwrap -> expect

    Centril committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    52fa020 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    db4818f View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    62714f8 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    30e84b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. Configuration menu
    Copy the full SHA
    a34c267 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#67148 - Centril:ty-polish, r=estebank

     Refactor type & bounds parsing thoroughly
    
    PR is based on rust-lang#67131 with first one from this PR being ` extract parse_ty_tuple_or_parens`.
    
    Also fixes rust-lang#67146.
    
    r? @estebank
    Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    616373e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#67410 - mati865:mingw_link_fix, r=Mark-Simu…

    …lacrum
    
    Reenable static linking of libstdc++ on windows-gnu
    
    Fixes rust-lang#67408
    
    Verified locally that `rustc_driver` is now statically linked to libstdc++.
    Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    35ff2f1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#67439 - Centril:clean-hair-slice, r=matthew…

    …jasper
    
    Cleanup `lower_pattern_unadjusted` & Improve slice pat typeck
    
    Following up on rust-lang#67318, in this PR, the HAIR lowering of patterns (`lower_pattern_unadjusted`) is cleaned up with a focus on slice patterns (in particular, some dead code is removed). Moreover, `check_pat_slice` is refactored some more.
    
    r? @matthewjasper
    Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    877dc9d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#67480 - rossmacarthur:fix-41260-avoid-issue…

    …-0-part-2, r=Centril
    
    Require issue = "none" over issue = "0" in unstable attributes
    
    These changes make the use of `issue = "none"` required in unstable attributes throughout the compiler.
    
    Notes:
    - rust-lang#66299 is now in beta so `issue = "none"` is accepted.
    - The `tidy` tool now fails on `issue = "0"`.
    - Tests that used `issue = "0"` were changed to use `issue = "none"`, except for _one_ that asserts `issue = "0"` can still be used.
    - The compiler still allows `issue = "0"` because some submodules require it, this could be disallowed once these are updated.
    
    Resolves rust-lang#41260
    
    r? @varkor
    Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    eaeb113 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#67500 - JohnTitor:non-shorthand-field-patte…

    …rns, r=Centril
    
    Tweak non_shorthand_field_patterns' suggestion
    
    Fixes rust-lang#66434
    
    r? @estebank
    Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    c355463 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#67504 - Mark-Simulacrum:note-data-offset, r…

    …=Centril
    
    Warn against relying on ?Sized being last
    
    Fixes rust-lang#62522
    Centril committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    ca528fc View commit details
    Browse the repository at this point in the history