Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #70378

Closed
wants to merge 14 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 25, 2020

Successful merges:

Failed merges:

r? @ghost

jeremystucki and others added 14 commits March 23, 2020 20:15
Now it only gates specific built-in attributes
Increase verbosity when using update syntax with private fields

Resolves rust-lang#70323
Update backtrace crate to 0.3.46

* Support line-tables-only when using libbacktrace
* Update libbacktrace to latest master
* Define HAVE_KERN_PROC on FreeBSD to fix rust-lang#54434
resolve: Remove `rustc_attrs` as a standalone feature gate

Now it only gates specific built-in attributes.

So if you want to make a rustc attribute, make it a built-in (this was already the case in practice for some time).
…r=Centril

Fix smaller issues with invalid placeholder type errors

Follow up to rust-lang#70294.

- Fix placement of suggested generic param when bounds are present.
- Reduce error duplication for invalid placeholder types in `fn` types.

r? @Centril
…acrum

normalize some imports & prefer direct ones

r? @Mark-Simulacrum
@Centril
Copy link
Contributor Author

Centril commented Mar 25, 2020

@bors retry

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 25, 2020
@Centril
Copy link
Contributor Author

Centril commented Mar 25, 2020

@bors r+ p=6 rollup=never

@bors
Copy link
Contributor

bors commented Mar 25, 2020

📌 Commit 9ddd70c has been approved by Centril

@bors
Copy link
Contributor

bors commented Mar 25, 2020

⌛ Testing commit 9ddd70c with merge dd6493e6a9f3ce41ea280f40bf3898e4430418a9...

@bors
Copy link
Contributor

bors commented Mar 25, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 25, 2020
@Centril Centril closed this Mar 25, 2020
@Centril Centril deleted the rollup-bgyyzvf branch March 25, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants