Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backtrace crate to 0.3.46 #70361

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Update backtrace crate to 0.3.46 #70361

merged 1 commit into from
Mar 25, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Mar 24, 2020 •
edited
Loading

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
@Mark-Simulacrum
Copy link
Member

Could you provide a link to the github diff between these two versions as well as a summary of the changes in the PR description? Thanks!

(That makes this both easier to review and helps with looking through Git commit history for changes)

@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 24, 2020

rust-lang/backtrace-rs@backtrace-sys-0.1.34...0.3.46

@Mark-Simulacrum
Copy link
Member

@bors r+

Thanks! I believe this also includes a fix for #69151, we'll want to check that but can be done after this lands.

@bors
Copy link
Contributor

bors commented Mar 24, 2020

📌 Commit 64a8c8a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2020
@bors
Copy link
Contributor

bors commented Mar 24, 2020

⌛ Testing commit 64a8c8a with merge 9501b80886c1826c527d63e730f780120ebf64e1...

Centril added a commit to Centril/rust that referenced this pull request Mar 25, 2020
@Centril
Rollup merge of rust-lang#70361 - tmiasko:backtrace, r=Mark-Simulacrum
761511a 
Update backtrace crate to 0.3.46

* Support line-tables-only when using libbacktrace
* Update libbacktrace to latest master
* Define HAVE_KERN_PROC on FreeBSD to fix rust-lang#54434
@Centril Centril mentioned this pull request Mar 25, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Mar 25, 2020

@bors retry

@bors
Copy link
Contributor

bors commented Mar 25, 2020

⌛ Testing commit 64a8c8a with merge a481b3ff79b11ad92a2652e50f6757a116485cc1...

Centril added a commit to Centril/rust that referenced this pull request Mar 25, 2020
@Centril
Rollup merge of rust-lang#70361 - tmiasko:backtrace, r=Mark-Simulacrum
bcef8a3 
Update backtrace crate to 0.3.46

* Support line-tables-only when using libbacktrace
* Update libbacktrace to latest master
* Define HAVE_KERN_PROC on FreeBSD to fix rust-lang#54434
@Centril Centril mentioned this pull request Mar 25, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Mar 25, 2020

@bors retry

@Centril Centril mentioned this pull request Mar 25, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2020
@bors
Auto merge of rust-lang#70383 - Centril:rollup-hmfft3y, r=Centril
cdb50c6 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70331 (Increase verbosity when using update syntax with private fields)
 - rust-lang#70349 (move `hir_id_validation` to `rustc_passes` + simplify `hir::map` code)
 - rust-lang#70361 (Update backtrace crate to 0.3.46)
 - rust-lang#70364 (resolve: Remove `rustc_attrs` as a standalone feature gate)
 - rust-lang#70369 (Fix smaller issues with invalid placeholder type errors)
 - rust-lang#70373 (normalize some imports & prefer direct ones)
 - rust-lang#70376 (Add test for rust-lang#66312)

Failed merges:

r? @ghost
@bors bors merged commit 3cced91 into rust-lang:master Mar 25, 2020
@tmiasko tmiasko deleted the backtrace branch March 25, 2020 09:10
@ehuss ehuss mentioned this pull request May 24, 2020
Closed
@Aaron1011 Aaron1011 mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backtraces have blank lines and <unknown> instead of function names on FreeBSD
5 participants
@tmiasko @rust-highfive @Mark-Simulacrum @bors @Centril