-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #71916
Rollup of 4 pull requests #71916
Commits on May 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 675b585 - Browse repository at this point
Copy the full SHA 675b585View commit details
Commits on May 4, 2020
-
Add Option to Force Unwind Tables
When panic != unwind, `nounwind` is added to all functions for a target. This can cause issues when a panic happens with RUST_BACKTRACE=1, as there needs to be a way to reconstruct the backtrace. There are three possible sources of this information: forcing frame pointers (for which an option exists already), debug info (for which an option exists), or unwind tables. Especially for embedded devices, forcing frame pointers can have code size overheads (RISC-V sees ~10% overheads, ARM sees ~2-3% overheads). In code, it can be the case that debug info is not kept, so it is useful to provide this third option, unwind tables, that users can use to reconstruct the call stack. Reconstructing this stack is harder than with frame pointers, but it is still possible. This commit adds a compiler option which allows a user to force the addition of unwind tables. Unwind tables cannot be disabled on targets that require them for correctness, or when using `-C panic=unwind`.
Configuration menu - View commit details
-
Copy full SHA for cda9946 - Browse repository at this point
Copy the full SHA cda9946View commit details -
Improve docs for embed-bitcode and linker-plugin-lto
Follow-up from rust-lang#71716 I wasn't able to add in time.
Configuration menu - View commit details
-
Copy full SHA for 0b35692 - Browse repository at this point
Copy the full SHA 0b35692View commit details
Commits on May 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ca72352 - Browse repository at this point
Copy the full SHA ca72352View commit details -
Rollup merge of rust-lang#69984 - lenary:lenary/force-uwtables, r=han…
…na-kruppe Add Option to Force Unwind Tables When panic != unwind, `nounwind` is added to all functions for a target. This can cause issues when a panic happens with RUST_BACKTRACE=1, as there needs to be a way to reconstruct the backtrace. There are three possible sources of this information: forcing frame pointers (for which an option exists already), debug info (for which an option exists), or unwind tables. Especially for embedded devices, forcing frame pointers can have code size overheads (RISC-V sees ~10% overheads, ARM sees ~2-3% overheads). In production code, it can be the case that debug info is not kept, so it is useful to provide this third option, unwind tables, that users can use to reconstruct the call stack. Reconstructing this stack is harder than with frame pointers, but it is still possible. --- This came up in discussion on rust-lang#69890, and turned out to be a fairly simple addition. r? @hanna-kruppe
Configuration menu - View commit details
-
Copy full SHA for 12fc1e0 - Browse repository at this point
Copy the full SHA 12fc1e0View commit details -
Rollup merge of rust-lang#71830 - oli-obk:subrepo_funness, r=Mark-Sim…
…ulacrum Remove clippy from some leftover lists of "possibly failing" tools rust-lang#70655 successfully made clippy get built and tested on CI on every merge, but the lack of emitted toolstate info caused the toolstate to get updated to test-fail. We should remove clippy entirely from toolstate, as it now is always test-pass. The changes made in this PR reflect what we do for `rustdoc`, which is our preexisting tool that is gated on CI. r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for a49d2b7 - Browse repository at this point
Copy the full SHA a49d2b7View commit details -
Rollup merge of rust-lang#71894 - mibac138:semicolon-not-always-helpf…
…ul, r=estebank Suggest removing semicolon in last expression only if it's type is known Fixes rust-lang#67971 Is there a syntax for explicitly checking if a note doesn't exist in test output? Something like `//~ !NOTE ...` I believe r? @estebank deals with diagnostics.
Configuration menu - View commit details
-
Copy full SHA for 67a7b7a - Browse repository at this point
Copy the full SHA 67a7b7aView commit details -
Rollup merge of rust-lang#71897 - alexcrichton:embed-bitcode-docs, r=…
…nnethercote Improve docs for embed-bitcode and linker-plugin-lto Follow-up from rust-lang#71716 I wasn't able to add in time.
Configuration menu - View commit details
-
Copy full SHA for 3efcba6 - Browse repository at this point
Copy the full SHA 3efcba6View commit details