Clean up E0590 explanation #72235
Merged
Clean up E0590 explanation #72235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Dylan-DPC-zz
suggested changes
May 16, 2020
| @@ -1,13 +1,17 @@ | |||
| `break` or `continue` must include a label when used in the condition of a | |||
| `while` loop. | |||
| `break` or `continue` keywords were used in a `while` loop condition without a | |||
There was a problem hiding this comment.
Suggested change
| `break` or `continue` keywords were used in a `while` loop condition without a | |
| `break` or `continue` keywords were used in a condition of a `while` loop without a |
GuillaumeGomez
force-pushed
the
cleanup-E0590
branch
from
cd3a992
to
985ebf2
Compare
|
Updated! |
|
@bors r+ rollup |
|
📌 Commit 985ebf2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#71829 (Fix suggestion to borrow in struct) - rust-lang#72123 (Stabilize process_set_argv0 feature for Unix) - rust-lang#72235 (Clean up E0590 explanation) - rust-lang#72345 (Clean up E0593 explanation) - rust-lang#72376 ([self-profling] Record the cgu name when doing codegen for a module) - rust-lang#72399 (Add fast-path optimization for Ipv4Addr::fmt) - rust-lang#72435 (rustllvm: Fix warnings about unused function parameters) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC