[self-profling] Record the cgu name when doing codegen for a module #72376
Conversation
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hm, this won't show up in self-profile summaries, right? If it does then we'll need to somehow disable that or patch perf.rlo somehow, I guess -- ideally perf sees the "same" query over time unless something has changed in a major way in the compiler. I guess CGU partitioning is maybe "major" change but it's unclear to me that we want that to mean two different queries on the detailed-query view. |
|
No, this is stored in the "args" field for the event. It won't show up anywhere except the chromium profiler currently. perf.rlo will be entirely unaffected. |
|
Great! Then this seems fine to me as well. @bors r+ |
|
📌 Commit 8ac1699 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Rollup of 7 pull requests Successful merges: - rust-lang#71829 (Fix suggestion to borrow in struct) - rust-lang#72123 (Stabilize process_set_argv0 feature for Unix) - rust-lang#72235 (Clean up E0590 explanation) - rust-lang#72345 (Clean up E0593 explanation) - rust-lang#72376 ([self-profling] Record the cgu name when doing codegen for a module) - rust-lang#72399 (Add fast-path optimization for Ipv4Addr::fmt) - rust-lang#72435 (rustllvm: Fix warnings about unused function parameters) Failed merges: r? @ghost
No description provided.