Finish moving to intra doc links for std::sync #76868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-intra-doc-links
rust-highfive
added
the
S-waiting-on-review
poliorcetics
force-pushed
the
intra-doc-std-sync
branch
from
a6ac09e
to
49e7729
Compare
poliorcetics
force-pushed
the
intra-doc-std-sync
branch
from
49e7729
to
b534d9f
Compare
jyn514
reviewed
Sep 18, 2020
| /// [`call_once_force`]: struct.Once.html#method.call_once_force | ||
| /// [`Once`]: struct.Once.html | ||
| /// State yielded to [`Once::call_once_force()`]’s closure parameter. The state | ||
| /// can be used to query the poison status of the [`Once`]. |
There was a problem hiding this comment.
Using "once" as a noun makes me uncomfortable :( unfortunately the name is stable so not much we can do about it
There was a problem hiding this comment.
I'm not sure what to do about it. I thought up some alternate wordings but they are not any better IMO:
the Once instancethe original Once
There was a problem hiding this comment.
Yeah, I don't think it needs to change, it's just unfortunate. 'the Once' makes it clear you're talking about an instance of the struct, it just sounds weird.
jyn514
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit aaddcdb has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 21, 2020
…jyn514 Finish moving to intra doc links for std::sync Helps with rust-lang#75080. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 21, 2020
…jyn514 Finish moving to intra doc links for std::sync Helps with rust-lang#75080. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 21, 2020
…jyn514 Finish moving to intra doc links for std::sync Helps with rust-lang#75080. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#76135 (Stabilize some Option methods as const) - rust-lang#76628 (Add sample defaults for config.toml ) - rust-lang#76846 (Avoiding unnecesary allocations at rustc_errors) - rust-lang#76867 (Use intra-doc links in core/src/iter when possible) - rust-lang#76868 (Finish moving to intra doc links for std::sync) - rust-lang#76872 (Remove DeclareMethods) - rust-lang#76936 (Add non-`unsafe` `.get_mut()` for `Unsafecell`) - rust-lang#76958 (Replace manual as_nanos and as_secs_f64 reimplementations) - rust-lang#76959 (Replace write_fmt with write!) - rust-lang#76961 (Add test for issue rust-lang#34634) - rust-lang#76962 (Use const_cstr macro in consts.rs) - rust-lang#76963 (Remove unused static_assert macro) - rust-lang#77000 (update Miri) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #75080.
@rustbot modify labels: T-doc A-intra-doc-links
r? @jyn514