Rollup of 12 pull requests #77509
Closed
Rollup of 12 pull requests #77509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow c-variadic associated functions - Add test for c-variadic functions in the Impl context
Remove trailing `-`.
The previous error was confusing since it made it sound like you can't link to items that are defined outside the current module. Also suggested importing the item.
The new error was confusing when there was partial resolution (something like `std::io::nonexistent`); the old one is better for those cases.
This matches Cargo behavior and avoids the (somewhat expensive) double checking, as well as the unfortunate duplicate error messages (#76822, rust-lang/cargo#5128).
This makes it easier to make rapid changes without having to constantly fix warnings.
rustc_ast_passes: allow c-variadic associated fns - Allow c-variadic associated functions - Add test for c-variadic functions in the Impl context Related To: #44930 CC: @jethrogb @sarvi r? @joshtriplett
Use `tracing` spans to trace the entire MIR interp stack r? @RalfJung While being very verbose, this allows really good tracking of what's going on. While I considered schemes like the previous indenter that we had (which we could get by using the `tracing-tree` crate), this will break down horribly with things like multithreaded rustc. Instead, we can now use `RUSTC_LOG` to restrict the things being traced. You could specify a filter in a way that only shows the logging of a specific frame.  If we lower the span's level to `debug`, then in `info` level logging we'd not see the frames, but in `debug` level we would see them. The filtering rules in `tracing` are super powerful, but I'm not sure if we can specify a filter so we do see `debug` level events, but *not* the `frame` spans. The documentation at https://docs.rs/tracing-subscriber/0.2.10/tracing_subscriber/struct.EnvFilter.html makes me think that we can only turn on things, not turn off things at a more precise level. cc @hawkw
Uplift drop-bounds lint from clippy Bounds on `T: Drop` do nothing, so they should warn.
BTreeMap: complete the compile-time test_variance test case Some of the items added to the new `test_sync` belonged in the old `test_variance` as well. And fixed inconsistent paths to nearby modules. r? @Mark-Simulacrum
BTreeMap: document DrainFilterInner better r? @Mark-Simulacrum
Fix test name Remove trailing `-`.
…yn514 Improve rustdoc error for failed intra-doc link resolution The previous error was confusing since it made it sound like you can't link to items that are defined outside the current module. Also suggested importing the item. r? @jyn514
Make --all-targets in x.py check opt-in In particular due to #76822, making this the default is currently suboptimal. r? @ecstatic-morse
Set `deny-warnings = false` in contributor defaults This makes it easier to make rapid changes without having to constantly fix warnings.
Support vectors with fewer than 8 elements for simd_select_bitmask Resolves the issue raised here: rust-lang/stdarch#310 (comment)
|
📌 Commit 5efe9be has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 5efe9be with merge 42f52601824eae3fd8ffa6e6e58e12e5473d76c0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tracingspans to trace the entire MIR interp stack #75143 (Usetracingspans to trace the entire MIR interp stack)deny-warnings = falsein contributor defaults #77492 (Setdeny-warnings = falsein contributor defaults)Failed merges:
r? @ghost