Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #83039

Closed
wants to merge 29 commits into from
Closed

Commits on Dec 26, 2020

  1. Configuration menu
    Copy the full SHA
    c71f523 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Configuration menu
    Copy the full SHA
    14e23f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Configuration menu
    Copy the full SHA
    a6624d3 View commit details
    Browse the repository at this point in the history
  2. update MSYS2 link in README

    Now https://msys2.github.io/ redirects to https://www.msys2.org/, so
    the README might just link to that immediately.
    tspiteri committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    3a3e7eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4d7046 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0d07153 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0666905 View commit details
    Browse the repository at this point in the history
  6. apply review

    mockersf committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    232b9f1 View commit details
    Browse the repository at this point in the history
  7. Add reexport tests

    aDotInTheVoid committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    9925ecb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5f24798 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Ignore Vim swap files

    camelid authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    68f50c8 View commit details
    Browse the repository at this point in the history
  2. rustdoc: tweak the search index format

    This essentially switches search-index.js from a "array of struct"
    to a "struct of array" format, like this:
    
        {
        "doc": "Crate documentation",
        "t": [ 1, 1, 2, 3, ... ],
        "n": [ "Something", "SomethingElse", "whatever", "do_stuff", ... ],
        "q": [ "a::b", "", "", "", ... ],
        "d": [ "A Struct That Does Something", "Another Struct", "a function", "another function", ... ],
        "i": [ 0, 0, 1, 1, ... ],
        "f": [ null, null, [], [], ... ],
        "p": ...,
        "a": ...
        }
    
    So `{ty: 1, name: "Something", path: "a::b", desc: "A Struct That Does Something", parent_idx: 0, search_type: null}` is the first item.
    
    This makes the uncompressed version smaller, but it really shows on the
    compressed version:
    
        notriddle:rust$ wc -c new-search-index1.52.0.js
        2622427 new-search-index1.52.0.js
        notriddle:rust$ wc -c old-search-index1.52.0.js
        2725046 old-search-index1.52.0.js
        notriddle:rust$ gzip new-search-index1.52.0.js
        notriddle:rust$ gzip old-search-index1.52.0.js
        notriddle:rust$ wc -c new-search-index1.52.0.js.gz
        239385 new-search-index1.52.0.js.gz
        notriddle:rust$ wc -c old-search-index1.52.0.js.gz
        296328 old-search-index1.52.0.js.gz
        notriddle:rust$
    
    That's a 4% improvement on the uncompressed version (fewer `[]`),
    and 20% improvement after gzipping it, thanks to putting like-typed
    data next to each other. Any compression algorithm based on a sliding
    window will probably show this kind of improvement.
    notriddle committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3934dd1 View commit details
    Browse the repository at this point in the history
  3. Adjust some #[cfg]s to take non-Unix non-Windows operating systems …

    …into account
    hyd-dev committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    00c0872 View commit details
    Browse the repository at this point in the history
  4. Reintroduce accidentally deleted assertions.

    These were removed in rust-lang#50198
    oli-obk committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c69b108 View commit details
    Browse the repository at this point in the history
  5. Update RLS

    Xanewok committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    ae5cc8a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a34428 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6bf4147 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#80385 - camelid:clarify-cell-replace-docs, …

    …r=Mark-Simulacrum
    
    Clarify what `Cell::replace` returns
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    eb6af16 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#82571 - aDotInTheVoid:reexport-tests, r=Cra…

    …ftSpider
    
    Rustdoc Json: Add tests for Reexports, and improve jsondocck
    
    The two changes are orthognal, so you can land just one if you want, but the improved errors realy helped write the tests.
    
    Notably does not have the case from rust-lang#80664, but I want to have all the ajacent cases tested before starting work on that to ensure I dont break anything.
    
    Improves rust-lang#81359
    
    cc ``@CraftSpider``
    
    r? ``@jyn514``
    
    ``@rustbot`` modify labels: +A-testsuite +T-rustdoc +A-rustdoc-json
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    c63a963 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#82860 - LeSeulArtichaut:unpretty-thir, r=sp…

    …astorino
    
    Add `-Z unpretty` flag for the THIR
    
    This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate.
    
    Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062.
    Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR.
    r? ``@spastorino`` cc ``@estebank``
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    26d4393 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#82950 - mockersf:slice-intra-doc-link, r=jy…

    …n514
    
    convert slice doc link to intra-doc links
    
    Continuing where rust-lang#80189 stopped, with `core::slice`.
    
    I had an issue with two dead links in my doc when implementing `Deref<Target = [T]>` for one of my type. This means that [`binary_search_by_key`](https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.binary_search_by_key) was available, but not [`sort_by_key`](https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.sort_by_key) even though it was linked in it's doc (same issue with [`as_ptr`](https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.as_ptr) and [`as_mut_pbr`](https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.as_mut_ptr)). It becomes available if I implement `DerefMut`, as it needs an `&mut self`.
    
    <details>
      <summary>Code that will have dead links in its doc</summary>
    
    ```rust
    pub struct A;
    pub struct B;
    
    impl std::ops::Deref for B{
        type Target = [A];
    
        fn deref(&self) -> &Self::Target {
            &A
        }
    }
    ```
    </details>
    
    I removed the link to `sort_by_key` from `binary_search_by_key` doc as I didn't find a nice way to have a live link:
    - `binary_search_by_key` is in `core`
    - `sort_by_key` is in `alloc`
    - intra-doc link `slice::sort_by_key` doesn't work, as `alloc` is not available when `core` is being build (the warning can't be ignored: ```error[E0710]: an unknown tool name found in scoped lint: `rustdoc::broken_intra_doc_links` ```)
    - keeping the link as an anchor `#method.sort_by_key` meant a dead link
    - an absolute link would work but doesn't feel right...
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    9b20fe2 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#82965 - XAMPPRocky:spv-ext, r=nagisa

    Add spirv extension handling in compiletest
    
    We're trying to use `compiletest` for Rust-GPU's testsuite, and ran into an issue with host specific extensions. This adds handling to fix that.
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e568795 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#82966 - tspiteri:msys2-link, r=Mark-Simulacrum

    update MSYS2 link in README
    
    Now https://msys2.github.io/ redirects to https://www.msys2.org/, so the README might just link to that immediately.
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b986f78 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#82979 - GuillaumeGomez:run-button-pos, r=Ne…

    …mo157
    
    Fix "run" button position in error index
    
    This isn't really a rustdoc issue but I still made the same fix in the `rustdoc.css` file (doesn't hurt).
    
    Before:
    
    ![Screenshot from 2021-03-10 16-35-49](https://user-images.githubusercontent.com/3050060/110655807-aa402800-81bf-11eb-8a88-bc979efd1697.png)
    
    After:
    
    ![Screenshot from 2021-03-10 16-40-08](https://user-images.githubusercontent.com/3050060/110655843-b4622680-81bf-11eb-8670-42975d92b4eb.png)
    
    cc ```@jyn514``` (considering this is quite a big bug and an easy fix)
    r? ```@Nemo157```
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    d682354 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#83001 - camelid:gitignore-vim-swap, r=Mark-…

    …Simulacrum
    
    Ignore Vim swap files
    
    I got this from [a Stack Overflow answer][so].
    (I didn't add `*~` because it was already there.)
    
    [so]: https://stackoverflow.com/a/4824199
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e4995c7 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#83003 - notriddle:rustdoc-index-v3, r=Guill…

    …aumeGomez
    
    rustdoc: tweak the search index format
    
    This essentially switches search-index.js from a "array of struct" to a "struct of array" format, like this:
    
        {
        "doc": "Crate documentation",
        "t": [ 1, 1, 2, 3, ... ],
        "n": [ "Something", "SomethingElse", "whatever", "do_stuff", ... ],
        "q": [ "a::b", "", "", "", ... ],
        "d": [ "A Struct That Does Something", "Another Struct", "a function", "another function", ... ],
        "i": [ 0, 0, 1, 1, ... ],
        "f": [ null, null, [], [], ... ],
        "p": ...,
        "a": ...
        }
    
    So `{ty: 1, name: "Something", path: "a::b", desc: "A Struct That Does Something", parent_idx: 0, search_type: null}` is the first item.
    
    This makes the uncompressed version smaller, but it really shows on the compressed version:
    
        notriddle:rust$ wc -c new-search-index1.52.0.js
        2622427 new-search-index1.52.0.js
        notriddle:rust$ wc -c old-search-index1.52.0.js
        2725046 old-search-index1.52.0.js
        notriddle:rust$ gzip new-search-index1.52.0.js
        notriddle:rust$ gzip old-search-index1.52.0.js
        notriddle:rust$ wc -c new-search-index1.52.0.js.gz
        239385 new-search-index1.52.0.js.gz
        notriddle:rust$ wc -c old-search-index1.52.0.js.gz
        296328 old-search-index1.52.0.js.gz
    
    That's a 4% improvement on the uncompressed version (fewer `[]`, and also changing `null` to `0` in the parent_idx list), and 20% improvement after gzipping it, thanks to putting like-typed data next to each other. Any compression algorithm based on a sliding window will probably show this kind of improvement.
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b31e9d5 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#83013 - hyd-dev:cfg-unix-windows, r=bjorn3

    Adjust some `#[cfg]`s to take non-Unix non-Windows operating systems into account
    
    This makes compilation to such targets (e.g. `wasm32-wasi`) easier.
    
    cc rust-lang/miri#722 rust-lang@bb6d1d0#r48100619
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b54ed1c View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#83018 - oli-obk:float_check, r=davidtwco

    Reintroduce accidentally deleted assertions.
    
    These were removed in rust-lang#50198
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    3c56110 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#83024 - Xanewok:update-rls, r=Dylan-DPC

    Update RLS
    
    Fixes rust-lang#82932
    
    r? ``@ghost``
    JohnTitor authored Mar 11, 2021
    Configuration menu
    Copy the full SHA
    9ad4625 View commit details
    Browse the repository at this point in the history