Rollup of 8 pull requests #85199
Merged
Rollup of 8 pull requests #85199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other sibling functions call this variable "slot", so "slote" was most likely a typo.
Right now it just shows the size.
Layout errors can occur with valid code, e.g. generic types.
At first you might think "why not just click through to the aliased type?", but if a type alias instantiates all of the generic parameters of the aliased type, then it can show layout info even though the aliased type cannot (because we can't compute the layout of a generic type). So I think it's still useful to show layout info for type aliases.
Co-authored-by: Ivan Tham <[email protected]>
This should prevent confusion about why generic types don't have layout docs.
There are issues with computing layout for type aliases; see rust-lang#85103. Once the issues are fixed, we should re-enable layout docs for them.
For boolean variables it's shorter and more readable to check the value directly, or negate it with `!`. In a couple of cases I reordered an if/else pair because it made the initial `if` statement simpler. Removed unused isType parameter from two functions.
… field for more libraries
…illaumeGomez rustdoc: Add unstable CLI option to show basic type layout information Closes rust-lang#75988. Right now it just shows the size.
…ebank shrinking the deprecated method span close rust-lang#84637
rustdoc: remove explicit boolean comparisons. For boolean variables it's shorter and more readable to check the value directly, or negate it with `!`. In a couple of cases I reordered an if/else pair because it made the initial `if` statement simpler. An example of a style guide recommending this: https://airbnb.io/javascript/#comparison--shortcuts r? `@GuillaumeGomez`
Change param name (k to key and v to value) in std::env module 1. When I was reading code the ide displayed `k` and `v`, so I thought it would be better to show key and value? 2. I noticed var method already uses `key` instead of `k` so it is more consistent to use `key` instead of `k`? Thanks
Fix typo in variable name All other sibling functions call this variable "slot", so "slote" was most likely a typo.
Use .name_str() to format primitive types in error messages This pull request fixes rust-lang#84976. The problem described there is caused by this code https://github.com/rust-lang/rust/blob/506e75cbf8cb5305e49a41326307004ca3976029/compiler/rustc_middle/src/ty/error.rs#L161-L166 using `Debug` formatting (`{:?}`), while the proper solution is to call `name_str()` of `ty::IntTy`, `ty::UintTy` and `ty::FloatTy`, respectively.
…tester, r=Mark-Simulacrum Improve rustdoc gui tester I cherry-picked the commit from rust-lang#84834 (and modified it a bit). I also used this opportunity to update it to last version (forgot to update GUI test in rust-lang#85074, really can't wait to make rust-lang#84586 finally work). cc `@Mark-Simulacrum` for the changes in bootstrap. r? `@jsha`
…-statements, r=tmandry Revert "Auto merge of rust-lang#84797 - richkadel:cover-unreachable-statements… This reverts commit e5f83d2, reversing changes made to ac888e8. See rust-lang#84797 (comment) r? `@tmandry`
|
@bors r+ p=8 rollup=never |
|
📌 Commit e27f20a has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
0of dead blocks #84797 - richkadel:cover-unreachable-statements…)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup