-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #85199
Rollup of 8 pull requests #85199
Commits on May 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f6dd332 - Browse repository at this point
Copy the full SHA f6dd332View commit details
Commits on May 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7c5bc20 - Browse repository at this point
Copy the full SHA 7c5bc20View commit details
Commits on May 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0778e8d - Browse repository at this point
Copy the full SHA 0778e8dView commit details -
All other sibling functions call this variable "slot", so "slote" was most likely a typo.
Configuration menu - View commit details
-
Copy full SHA for 41779f6 - Browse repository at this point
Copy the full SHA 41779f6View commit details
Commits on May 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f740923 - Browse repository at this point
Copy the full SHA f740923View commit details -
rustdoc: Show basic type layout information
Right now it just shows the size.
Configuration menu - View commit details
-
Copy full SHA for 001f0dd - Browse repository at this point
Copy the full SHA 001f0ddView commit details -
Layout errors can occur with valid code, e.g. generic types.
Configuration menu - View commit details
-
Copy full SHA for 5859c5d - Browse repository at this point
Copy the full SHA 5859c5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20b30ac - Browse repository at this point
Copy the full SHA 20b30acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9859e2b - Browse repository at this point
Copy the full SHA 9859e2bView commit details -
Show memory layout for type aliases
At first you might think "why not just click through to the aliased type?", but if a type alias instantiates all of the generic parameters of the aliased type, then it can show layout info even though the aliased type cannot (because we can't compute the layout of a generic type). So I think it's still useful to show layout info for type aliases.
Configuration menu - View commit details
-
Copy full SHA for 48da66f - Browse repository at this point
Copy the full SHA 48da66fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ee920 - Browse repository at this point
Copy the full SHA 12ee920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9615d6d - Browse repository at this point
Copy the full SHA 9615d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for db3a06d - Browse repository at this point
Copy the full SHA db3a06dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8048c70 - Browse repository at this point
Copy the full SHA 8048c70View commit details -
Apply suggestions from code review
Co-authored-by: Ivan Tham <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bcbc727 - Browse repository at this point
Copy the full SHA bcbc727View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a8479 - Browse repository at this point
Copy the full SHA 61a8479View commit details -
Configuration menu - View commit details
-
Copy full SHA for 879a914 - Browse repository at this point
Copy the full SHA 879a914View commit details -
Add note to docs when layout cannot be computed
This should prevent confusion about why generic types don't have layout docs.
Configuration menu - View commit details
-
Copy full SHA for 8b9298b - Browse repository at this point
Copy the full SHA 8b9298bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b89d01 - Browse repository at this point
Copy the full SHA 9b89d01View commit details -
Disable layout docs for type aliases for now
There are issues with computing layout for type aliases; see rust-lang#85103. Once the issues are fixed, we should re-enable layout docs for them.
Configuration menu - View commit details
-
Copy full SHA for d43701c - Browse repository at this point
Copy the full SHA d43701cView commit details -
rustdoc: remove explicit boolean comparisons.
For boolean variables it's shorter and more readable to check the value directly, or negate it with `!`. In a couple of cases I reordered an if/else pair because it made the initial `if` statement simpler. Removed unused isType parameter from two functions.
Configuration menu - View commit details
-
Copy full SHA for f510e41 - Browse repository at this point
Copy the full SHA f510e41View commit details -
Move rustdoc-gui rust libraries into their own folder and prepare the…
… field for more libraries
Configuration menu - View commit details
-
Copy full SHA for d5a24b0 - Browse repository at this point
Copy the full SHA d5a24b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b0976c - Browse repository at this point
Copy the full SHA 1b0976cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b94990 - Browse repository at this point
Copy the full SHA 6b94990View commit details -
Configuration menu - View commit details
-
Copy full SHA for bea112b - Browse repository at this point
Copy the full SHA bea112bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a4ae2 - Browse repository at this point
Copy the full SHA 69a4ae2View commit details -
Rollup merge of rust-lang#83501 - camelid:rustdoc-layout, r=jyn514,Gu…
…illaumeGomez rustdoc: Add unstable CLI option to show basic type layout information Closes rust-lang#75988. Right now it just shows the size.
Configuration menu - View commit details
-
Copy full SHA for 40be1d3 - Browse repository at this point
Copy the full SHA 40be1d3View commit details -
Rollup merge of rust-lang#85018 - hi-rustin:rustin-patch-84637, r=est…
…ebank shrinking the deprecated method span close rust-lang#84637
Configuration menu - View commit details
-
Copy full SHA for 649b385 - Browse repository at this point
Copy the full SHA 649b385View commit details -
Rollup merge of rust-lang#85124 - jsha:trust-the-bool, r=GuillaumeGomez
rustdoc: remove explicit boolean comparisons. For boolean variables it's shorter and more readable to check the value directly, or negate it with `!`. In a couple of cases I reordered an if/else pair because it made the initial `if` statement simpler. An example of a style guide recommending this: https://airbnb.io/javascript/#comparison--shortcuts r? `@GuillaumeGomez`
Configuration menu - View commit details
-
Copy full SHA for 4ab3050 - Browse repository at this point
Copy the full SHA 4ab3050View commit details -
Rollup merge of rust-lang#85136 - shirshak55:master, r=dtolnay
Change param name (k to key and v to value) in std::env module 1. When I was reading code the ide displayed `k` and `v`, so I thought it would be better to show key and value? 2. I noticed var method already uses `key` instead of `k` so it is more consistent to use `key` instead of `k`? Thanks
Configuration menu - View commit details
-
Copy full SHA for 6ec4f91 - Browse repository at this point
Copy the full SHA 6ec4f91View commit details -
Rollup merge of rust-lang#85162 - LingMan:patch-1, r=varkor
Fix typo in variable name All other sibling functions call this variable "slot", so "slote" was most likely a typo.
Configuration menu - View commit details
-
Copy full SHA for 9ad5c4d - Browse repository at this point
Copy the full SHA 9ad5c4dView commit details -
Rollup merge of rust-lang#85187 - FabianWolff:issue-84976, r=jackh726
Use .name_str() to format primitive types in error messages This pull request fixes rust-lang#84976. The problem described there is caused by this code https://github.com/rust-lang/rust/blob/506e75cbf8cb5305e49a41326307004ca3976029/compiler/rustc_middle/src/ty/error.rs#L161-L166 using `Debug` formatting (`{:?}`), while the proper solution is to call `name_str()` of `ty::IntTy`, `ty::UintTy` and `ty::FloatTy`, respectively.
Configuration menu - View commit details
-
Copy full SHA for c4c654f - Browse repository at this point
Copy the full SHA c4c654fView commit details -
Rollup merge of rust-lang#85191 - GuillaumeGomez:improve-rustdoc-gui-…
…tester, r=Mark-Simulacrum Improve rustdoc gui tester I cherry-picked the commit from rust-lang#84834 (and modified it a bit). I also used this opportunity to update it to last version (forgot to update GUI test in rust-lang#85074, really can't wait to make rust-lang#84586 finally work). cc `@Mark-Simulacrum` for the changes in bootstrap. r? `@jsha`
Configuration menu - View commit details
-
Copy full SHA for 8f3c2cc - Browse repository at this point
Copy the full SHA 8f3c2ccView commit details -
Rollup merge of rust-lang#85196 - richkadel:reverts-cover-unreachable…
…-statements, r=tmandry Revert "Auto merge of rust-lang#84797 - richkadel:cover-unreachable-statements… This reverts commit e5f83d2, reversing changes made to ac888e8. See rust-lang#84797 (comment) r? `@tmandry`
Configuration menu - View commit details
-
Copy full SHA for e27f20a - Browse repository at this point
Copy the full SHA e27f20aView commit details